diff options
| author | Martin Matuska <martin@matuska.org> | 2020-01-18 01:18:43 +0100 |
|---|---|---|
| committer | Martin Matuska <martin@matuska.org> | 2020-01-18 01:23:49 +0100 |
| commit | 06721c2ad050be144e4cc1719f197fbcfba438eb (patch) | |
| tree | dd6cba92f5f54beaee74c040fa98d9fb233b07d6 | |
| parent | 9f67e742b55e83b10b3dcf2df263c6bf43970e91 (diff) | |
| download | libarchive-06721c2ad050be144e4cc1719f197fbcfba438eb.tar.gz | |
RAR5 reader: fix unsafe sign check of a bitwise operation.
This has no but code correctness effect as cdeque_init() is static
and max_capacity_power_of_2 in our code is always 8192.
Found by LGTM.com code analysis
| -rw-r--r-- | libarchive/archive_read_support_format_rar5.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libarchive/archive_read_support_format_rar5.c b/libarchive/archive_read_support_format_rar5.c index 26374582..1c1cd796 100644 --- a/libarchive/archive_read_support_format_rar5.c +++ b/libarchive/archive_read_support_format_rar5.c @@ -384,7 +384,7 @@ static int cdeque_init(struct cdeque* d, int max_capacity_power_of_2) { d->cap_mask = max_capacity_power_of_2 - 1; d->arr = NULL; - if((max_capacity_power_of_2 & d->cap_mask) > 0) + if((max_capacity_power_of_2 & d->cap_mask) != 0) return CDE_PARAM; cdeque_clear(d); |