From 0eac3985f068dfda69840264090a5b0f26def3fd Mon Sep 17 00:00:00 2001 From: Martin Matuska Date: Thu, 8 Dec 2022 16:26:37 +0100 Subject: test_main.c: omit always-true comparsion Reported by: CodeQL Code Scanning Alert: 127 --- test_utils/test_main.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/test_utils/test_main.c b/test_utils/test_main.c index f5f5a713..74250ad7 100644 --- a/test_utils/test_main.c +++ b/test_utils/test_main.c @@ -3190,14 +3190,12 @@ extract_reference_file(const char *name) while (bytes > 0) { int n = 0; /* Write out 1-3 bytes from that. */ - if (bytes > 0) { - assert(VALID_UUDECODE(p[0])); - assert(VALID_UUDECODE(p[1])); - n = UUDECODE(*p++) << 18; - n |= UUDECODE(*p++) << 12; - fputc(n >> 16, out); - --bytes; - } + assert(VALID_UUDECODE(p[0])); + assert(VALID_UUDECODE(p[1])); + n = UUDECODE(*p++) << 18; + n |= UUDECODE(*p++) << 12; + fputc(n >> 16, out); + --bytes; if (bytes > 0) { assert(VALID_UUDECODE(p[0])); n |= UUDECODE(*p++) << 6; -- cgit v1.2.1