From 82e5c297d150255e0abcdf9ac991a3f6c0038ada Mon Sep 17 00:00:00 2001 From: Martin Matuska Date: Wed, 7 Dec 2022 15:52:54 +0100 Subject: cab reader: cast to int when subtracting unsigned integers Found by: GitHub CodeQL --- libarchive/archive_read_support_format_cab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libarchive/archive_read_support_format_cab.c b/libarchive/archive_read_support_format_cab.c index ea256cda..4d5029b1 100644 --- a/libarchive/archive_read_support_format_cab.c +++ b/libarchive/archive_read_support_format_cab.c @@ -1134,7 +1134,7 @@ cab_checksum_update(struct archive_read *a, size_t bytes) } if (sumbytes) { int odd = sumbytes & 3; - if (sumbytes - odd > 0) + if ((int)(sumbytes - odd) > 0) cfdata->sum_calculated = cab_checksum_cfdata_4( p, sumbytes - odd, cfdata->sum_calculated); if (odd) -- cgit v1.2.1