diff options
| author | Adam Jackson <ajax@redhat.com> | 2018-05-15 12:55:55 -0400 |
|---|---|---|
| committer | Adam Jackson <ajax@redhat.com> | 2018-05-17 12:03:33 -0400 |
| commit | 707f50e680ab4f1861b1e54ca6e2907aaca56c12 (patch) | |
| tree | 8f0872d826159920de6e0299c8cfe88c7f0d01f4 | |
| parent | c00c889e625164fc9507f84e57f40c9962e650bb (diff) | |
| download | libepoxy-707f50e680ab4f1861b1e54ca6e2907aaca56c12.tar.gz | |
dispatch: Try harder to avoid calling the resolver1.5.2
Our caller may load (eg) epoxy_glAlphaFunc, which is a function pointer,
and then call through that value multiple times. Until the caller
re-examines the value of that function pointer, which is a copy
relocation in the executable, repeated calls mean repeated work
resolving the GL function.
We can't make the caller reinspect the variable, but the resolver
function can avoid doing redundant work.
Fixes: anholt/libepoxy#171
Signed-off-by: Adam Jackson <ajax@redhat.com>
| -rw-r--r-- | src/dispatch_common.h | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/dispatch_common.h b/src/dispatch_common.h index fc99635..dcb3a35 100644 --- a/src/dispatch_common.h +++ b/src/dispatch_common.h @@ -85,10 +85,11 @@ #define WRAPPER(x) x ## _wrapped #define GEN_GLOBAL_REWRITE_PTR(name, args, passthrough) \ - static void EPOXY_CALLSPEC \ + static void EPOXY_CALLSPEC \ name##_global_rewrite_ptr args \ { \ - name = (void *)name##_resolver(); \ + if (name == (void *)name##_global_rewrite_ptr) \ + name = (void *)name##_resolver(); \ name passthrough; \ } @@ -96,7 +97,8 @@ static ret EPOXY_CALLSPEC \ name##_global_rewrite_ptr args \ { \ - name = (void *)name##_resolver(); \ + if (name == (void *)name##_global_rewrite_ptr) \ + name = (void *)name##_resolver(); \ return name passthrough; \ } |