From 082e4799d81149a9f0ca4e9d8afc65e64118fec0 Mon Sep 17 00:00:00 2001 From: Tim Burke Date: Thu, 8 Jun 2017 19:46:25 +0000 Subject: Negative data or parity args are invalid While we're at it, tighten up some test_create_backend_invalid_args assertions. Change-Id: Id6c70cdb2d86580280ededc3ec6ec648c6cb7d57 --- test/liberasurecode_test.c | 36 +++++++++++++++++------------------- 1 file changed, 17 insertions(+), 19 deletions(-) (limited to 'test') diff --git a/test/liberasurecode_test.c b/test/liberasurecode_test.c index 4791ca9..071889f 100644 --- a/test/liberasurecode_test.c +++ b/test/liberasurecode_test.c @@ -518,32 +518,30 @@ static void test_backend_available_invalid_args() static void test_create_backend_invalid_args() { int desc = liberasurecode_instance_create(-1, &null_args); - if (-EBACKENDNOTAVAIL == desc) { - fprintf (stderr, "Backend library not available!\n"); - return; - } - assert(desc < 0); + assert(-EBACKENDNOTSUPP == desc); + desc = liberasurecode_instance_create(EC_BACKENDS_MAX, &null_args); - if (-EBACKENDNOTAVAIL == desc) { - fprintf (stderr, "Backend library not available!\n"); - return; - } - assert(desc < 0); + assert(-EBACKENDNOTSUPP == desc); + desc = liberasurecode_instance_create(EC_BACKEND_NULL, NULL); - if (-EBACKENDNOTAVAIL == desc) { - fprintf (stderr, "Backend library not available!\n"); - return; - } + assert(-EINVALIDPARAMS == desc); + struct ec_args invalid_args = { .k = 100, .m = 100, }; desc = liberasurecode_instance_create(EC_BACKEND_NULL, &invalid_args); - if (-EBACKENDNOTAVAIL == desc) { - fprintf (stderr, "Backend library not available!\n"); - return; - } - assert(desc < 0); + assert(-EINVALIDPARAMS == desc); + + invalid_args.k = -1; + invalid_args.m = 4; + desc = liberasurecode_instance_create(EC_BACKEND_NULL, &invalid_args); + assert(-EINVALIDPARAMS == desc); + + invalid_args.k = 10; + invalid_args.m = -1; + desc = liberasurecode_instance_create(EC_BACKEND_NULL, &invalid_args); + assert(-EINVALIDPARAMS == desc); } static void test_destroy_backend_invalid_args() -- cgit v1.2.1