diff options
| author | Peter Hutterer <peter.hutterer@who-t.net> | 2013-09-16 15:55:10 +1000 |
|---|---|---|
| committer | Peter Hutterer <peter.hutterer@who-t.net> | 2013-09-16 15:55:10 +1000 |
| commit | 3dc41b29b740b9afd3c2b821af1f1ce3070c9fcf (patch) | |
| tree | 6365c81f88c0012d57f4663be4a1c5e119e142cb | |
| parent | f5e65ea3ce2541fe8ccfafe9b0dd04325da75b34 (diff) | |
| download | libevdev-3dc41b29b740b9afd3c2b821af1f1ce3070c9fcf.tar.gz | |
Revert "Reintroduce -fstack-protector"
http://lists.freedesktop.org/archives/input-tools/2013-September/000332.html
See above a detailed reasoning, but Colin Walters put it this way:
"At a high level, I think components (git repositories) should feel free
to set up default warning flags and possibly use a targeted subset of
-Werror=foo. But please don't inject non-warning flags like this unless
there is a very good reason.
The right way to do -fstack-protector is to have something like
redhat-rpm-config or other global CFLAGS system controlling *all*
components."
Thus, reverting the -fstack-protector flag. This doesn't completely address
Colin's comments, we still use a few other flags. But this one is the one
that causes real headaches, so drop it.
This reverts commit f5e65ea3ce2541fe8ccfafe9b0dd04325da75b34.
| -rw-r--r-- | configure.ac | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/configure.ac b/configure.ac index c32b06f..40675ef 100644 --- a/configure.ac +++ b/configure.ac @@ -67,7 +67,6 @@ if test "x$GCC" = "xyes"; then -fdata-sections \ -fno-strict-aliasing \ -fdiagnostics-show-option \ - -fstack-protector \ -fno-common]) fi AC_SUBST([GCC_CFLAGS], $with_cflags) |