From e96e98aea5ed9f69641e74b39153747218990bdc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C5=93ur?= Date: Thu, 2 Mar 2023 13:43:54 +0800 Subject: evdns: fix "Branch condition evaluates to a garbage value" in reply_parse --- evdns.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/evdns.c b/evdns.c index 05e515c0..4e8ee21d 100644 --- a/evdns.c +++ b/evdns.c @@ -1265,6 +1265,8 @@ reply_parse(struct evdns_base *base, u8 *packet, int length) struct request *req = NULL; unsigned int i, buf_size; + memset(&reply, 0, sizeof(reply)); + ASSERT_LOCKED(base); GET16(trans_id); @@ -1280,8 +1282,6 @@ reply_parse(struct evdns_base *base, u8 *packet, int length) if (!req) return -1; EVUTIL_ASSERT(req->base == base); - memset(&reply, 0, sizeof(reply)); - /* If it's not an answer, it doesn't correspond to any request. */ if (!(flags & _QR_MASK)) return -1; /* must be an answer */ if ((flags & (_RCODE_MASK|_TC_MASK)) && (flags & (_RCODE_MASK|_TC_MASK)) != DNS_ERR_NOTEXIST) { -- cgit v1.2.1