diff options
| author | Rhodri James <rhodri@kynesim.co.uk> | 2017-07-27 15:02:31 +0100 |
|---|---|---|
| committer | Rhodri James <rhodri@kynesim.co.uk> | 2017-07-27 15:02:31 +0100 |
| commit | 111bfd79b8fb83e133cbe98da3b26bd911eface1 (patch) | |
| tree | 7851f7e6c43bb494e94c1ccb0fc2193f7fe78509 | |
| parent | a8a79811d70836fe1fab5b5fff872922993a3142 (diff) | |
| download | libexpat-git-111bfd79b8fb83e133cbe98da3b26bd911eface1.tar.gz | |
Use named constant for magic number in external_entity_dbl_handler
| -rw-r--r-- | expat/tests/runtests.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/expat/tests/runtests.c b/expat/tests/runtests.c index 45c3a4a9..e198114b 100644 --- a/expat/tests/runtests.c +++ b/expat/tests/runtests.c @@ -8197,6 +8197,7 @@ external_entity_dbl_handler(XML_Parser parser, const char *text; XML_Parser new_parser; int i; +#define MAX_ALLOC_COUNT 20 if (callno == 0) { /* First time through, check how many calls to malloc occur */ @@ -8215,7 +8216,7 @@ external_entity_dbl_handler(XML_Parser parser, text = ("<?xml version='1.0' encoding='us-ascii'?>" "<e/>"); /* Try at varying levels to exercise more code paths */ - for (i = 0; i < 20; i++) { + for (i = 0; i < MAX_ALLOC_COUNT; i++) { allocation_count = callno + i; new_parser = XML_ExternalEntityParserCreate(parser, context, @@ -8228,7 +8229,7 @@ external_entity_dbl_handler(XML_Parser parser, XML_ParserFree(new_parser); return XML_STATUS_ERROR; } - else if (i == 20) { + else if (i == MAX_ALLOC_COUNT) { fail("Second external parser not created"); return XML_STATUS_ERROR; } @@ -8241,6 +8242,7 @@ external_entity_dbl_handler(XML_Parser parser, } XML_ParserFree(new_parser); return XML_STATUS_OK; +#undef MAX_ALLOC_COUNT } /* Test that running out of memory in dtdCopy is correctly reported. |