From 7875a3337783227aca58f63d2589635821ca15bc Mon Sep 17 00:00:00 2001 From: Pierre Joye Date: Tue, 1 Feb 2022 22:53:37 +0700 Subject: partial #818, fix again that logic. I need to find something more generic and convenient to handle errors, assert and free used resources on fail assert --- tests/tiff/tiff_invalid_read.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/tiff/tiff_invalid_read.c b/tests/tiff/tiff_invalid_read.c index c79ea90..3fd2a63 100644 --- a/tests/tiff/tiff_invalid_read.c +++ b/tests/tiff/tiff_invalid_read.c @@ -53,7 +53,7 @@ static size_t read_test_file(char **buffer, char *basename) } exp_size = ftell(fp); - if (!gdTestAssert(exp_size > 0)) { + if (exp_size <= 0) { gdTestAssert(1==0); // only increase num failures used as return values in main goto fail2; } @@ -64,9 +64,11 @@ static size_t read_test_file(char **buffer, char *basename) } *buffer = malloc(exp_size); - if (gdTestAssert(*buffer != NULL)) { + if (*buffer != NULL) { act_size = fread(*buffer, sizeof(**buffer), exp_size, fp); gdTestAssert(act_size == exp_size); + } else { + gdTestAssert(0); } fail2: -- cgit v1.2.1