<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/libgit2.git, branch rb/fix-2333</title>
<subtitle>github.com: libgit2/libgit2.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/'/>
<entry>
<title>Be more careful with user-supplied buffers</title>
<updated>2014-05-08T17:17:14+00:00</updated>
<author>
<name>Russell Belfer</name>
<email>rb@github.com</email>
</author>
<published>2014-05-08T17:17:14+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=1e4976cb015bd10a2a8c377e02801306473afc26'/>
<id>1e4976cb015bd10a2a8c377e02801306473afc26</id>
<content type='text'>
This adds in missing calls to `git_buf_sanitize` and fixes a
number of places where `git_buf` APIs could inadvertently write
NUL terminator bytes into invalid buffers.  This also changes the
behavior of `git_buf_sanitize` to NUL terminate a buffer if it can
and of `git_buf_shorten` to do nothing if it can.

Adds tests of filtering code with zeroed (i.e. unsanitized) buffer
which was previously triggering a segfault.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This adds in missing calls to `git_buf_sanitize` and fixes a
number of places where `git_buf` APIs could inadvertently write
NUL terminator bytes into invalid buffers.  This also changes the
behavior of `git_buf_sanitize` to NUL terminate a buffer if it can
and of `git_buf_shorten` to do nothing if it can.

Adds tests of filtering code with zeroed (i.e. unsanitized) buffer
which was previously triggering a segfault.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #2329 from anuraggup/fix_git_shutdown</title>
<updated>2014-05-06T23:11:03+00:00</updated>
<author>
<name>Russell Belfer</name>
<email>rb@github.com</email>
</author>
<published>2014-05-06T23:11:03+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=ed476c236b8328c31acb150ee69eaf00c821b9e3'/>
<id>ed476c236b8328c31acb150ee69eaf00c821b9e3</id>
<content type='text'>
Fix the issues in git_shutdown</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix the issues in git_shutdown</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #2324 from libgit2/cmn/file-in-objects-dir</title>
<updated>2014-05-06T21:03:58+00:00</updated>
<author>
<name>Russell Belfer</name>
<email>rb@github.com</email>
</author>
<published>2014-05-06T21:03:58+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=1051100025c1075fa1b7f003dad7db086791b583'/>
<id>1051100025c1075fa1b7f003dad7db086791b583</id>
<content type='text'>
odb: ignore files in the objects dir</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
odb: ignore files in the objects dir</pre>
</div>
</content>
</entry>
<entry>
<title>Fix the issues in git_shutdown</title>
<updated>2014-05-06T20:41:07+00:00</updated>
<author>
<name>Anurag Gupta</name>
<email>anugupta@microsoft.com</email>
</author>
<published>2014-05-06T20:33:47+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=0bf5430dc77c69d2b2d27a771b584b17cedb97ec'/>
<id>0bf5430dc77c69d2b2d27a771b584b17cedb97ec</id>
<content type='text'>
1) Call to git_shutdown results in setting git__n_shutdown_callbacks
to -1. Next call to git__on_shutdown results in ABW (Array Bound Write)
for array git__shutdown_callbacks. In the current Implementation,
git_atomic_dec is called git__n_shutdown_callbacks + 1 times. I have
modified it to a for loop so that it is more readable. It would not
set git__n_shutdown_callbacks to a negative number and reset the
elements of git__shutdown_callbacks to NULL.

2) In function git_sysdir_get, shutdown function is registered only if
git_sysdir__dirs_shutdown_set is set to 0. However, after this variable
is set to 1, it is never reset to 0. If git_sysdir_global_init is
called again from synchronized_threads_init it does not register
shutdown function for this subsystem.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
1) Call to git_shutdown results in setting git__n_shutdown_callbacks
to -1. Next call to git__on_shutdown results in ABW (Array Bound Write)
for array git__shutdown_callbacks. In the current Implementation,
git_atomic_dec is called git__n_shutdown_callbacks + 1 times. I have
modified it to a for loop so that it is more readable. It would not
set git__n_shutdown_callbacks to a negative number and reset the
elements of git__shutdown_callbacks to NULL.

2) In function git_sysdir_get, shutdown function is registered only if
git_sysdir__dirs_shutdown_set is set to 0. However, after this variable
is set to 1, it is never reset to 0. If git_sysdir_global_init is
called again from synchronized_threads_init it does not register
shutdown function for this subsystem.
</pre>
</div>
</content>
</entry>
<entry>
<title>object: fix a brace</title>
<updated>2014-05-06T19:29:55+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2014-05-06T19:14:58+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=6e9afb97d14545f9cea292f581de89d610ae8c07'/>
<id>6e9afb97d14545f9cea292f581de89d610ae8c07</id>
<content type='text'>
The brace in the check for peel's return was surrounding the wrong
thing, which made 'error' be set to 1 when there was an error instead of
the error code.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The brace in the check for peel's return was surrounding the wrong
thing, which made 'error' be set to 1 when there was an error instead of
the error code.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix the issues in git__on_shutdown</title>
<updated>2014-05-06T19:16:24+00:00</updated>
<author>
<name>Anurag Gupta</name>
<email>anugupta@microsoft.com</email>
</author>
<published>2014-05-06T19:16:24+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=001befcdd5a208a046e0196e3fec7b16041cfe14'/>
<id>001befcdd5a208a046e0196e3fec7b16041cfe14</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>odb: ignore files in the objects dir</title>
<updated>2014-05-05T14:34:18+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2014-05-05T14:04:14+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=ee311907ee0299ff2c1d7fc37699dc3e4da20c52'/>
<id>ee311907ee0299ff2c1d7fc37699dc3e4da20c52</id>
<content type='text'>
We assume that everything under GIT_DIR/objects/ is a directory. This is
not necessarily the case if some process left a stray file in there.

Check beforehand if we do have a directory and ignore the entry
otherwise.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We assume that everything under GIT_DIR/objects/ is a directory. This is
not necessarily the case if some process left a stray file in there.

Check beforehand if we do have a directory and ignore the entry
otherwise.
</pre>
</div>
</content>
</entry>
<entry>
<title>Doc fixes</title>
<updated>2014-05-02T22:15:43+00:00</updated>
<author>
<name>Russell Belfer</name>
<email>rb@github.com</email>
</author>
<published>2014-05-02T22:15:43+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=d2c16e9ac4921e94eb5db972e6b8452d71a623fc'/>
<id>d2c16e9ac4921e94eb5db972e6b8452d71a623fc</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #2308 from libgit2/rb/diff-update-index-stat-cache</title>
<updated>2014-05-02T16:50:15+00:00</updated>
<author>
<name>Vicent Marti</name>
<email>vicent@github.com</email>
</author>
<published>2014-05-02T16:50:15+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=272b462db7cfb50c1ab69e1edda214b21f242ae5'/>
<id>272b462db7cfb50c1ab69e1edda214b21f242ae5</id>
<content type='text'>
Reduce excessive OID calculation for diff and stat</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Reduce excessive OID calculation for diff and stat</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #2310 from libgit2/cmn/commit-create-safe</title>
<updated>2014-05-02T16:42:07+00:00</updated>
<author>
<name>Russell Belfer</name>
<email>rb@github.com</email>
</author>
<published>2014-05-02T16:42:07+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=9862ef8ef8ffd95a74be8082acab9fea0de85edb'/>
<id>9862ef8ef8ffd95a74be8082acab9fea0de85edb</id>
<content type='text'>
commit: safer commit creation with reference update</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
commit: safer commit creation with reference update</pre>
</div>
</content>
</entry>
</feed>
