delta/libgit2.git/tests/index/crlf.c, branch ethomson/test_https

path: separate git-specific path functions from util

2021-11-09T15:17:17+00:00

Introduce `git_fs_path`, which operates on generic filesystem paths.
`git_path` will be kept for only git-specific path functionality (for
example, checking for `.git` in a path).

str: introduce `git_str` for internal, `git_buf` is external

2021-10-17T13:49:01+00:00

libgit2 has two distinct requirements that were previously solved by
`git_buf`.  We require:

1. A general purpose string class that provides a number of utility APIs
   for manipulating data (eg, concatenating, truncating, etc).
2. A structure that we can use to return strings to callers that they
   can take ownership of.

By using a single class (`git_buf`) for both of these purposes, we have
confused the API to the point that refactorings are difficult and
reasoning about correctness is also difficult.

Move the utility class `git_buf` to be called `git_str`: this represents
its general purpose, as an internal string buffer class.  The name also
is an homage to Junio Hamano ("gitstr").

The public API remains `git_buf`, and has a much smaller footprint.  It
is generally only used as an "out" param with strict requirements that
follow the documentation.  (Exceptions exist for some legacy APIs to
avoid breaking callers unnecessarily.)

Utility functions exist to convert a user-specified `git_buf` to a
`git_str` so that we can call internal functions, then converting it
back again.

clar: include the function name

2020-06-05T07:49:07+00:00

git_error: use new names in internal APIs and usage

2019-01-22T22:30:35+00:00

Move to the `git_error` name in the internal API for error-related
functions.

Fix Linux warnings

2019-01-09T01:26:14+00:00

This change fixes -Wmaybe-uninitialized and -Wdeprecated-declarations
warnings on Linux builds

tests: add missing asserts

2019-01-04T12:41:50+00:00

CID 1398597, 1398598

Additional core.autocrlf and core.safecrlf tests

2018-12-04T01:02:10+00:00

This is a cherry-pick of the tests from the following commits:

core.autocrlf=true and core.safecrlf=true did not fail on LF-only file as vanilla git does
Adding a CRLF-file with core.autocrlf=input and core.safecrlf=true does not fail as with vanilla git
Make files with #CR!=#CRLF not fail with core.safecrlf=true

Reported-by: Yue Lin Ho 
Signed-off-by: Sven Strickroth

index::crlf: better error reporting in core git tests

2018-12-04T01:02:09+00:00

Don't simply fail when the expected output does not match the data in
the index; instead, provide a detailed output about the system, file,
and settings that caused the failure so that developers can better
isolate the problem(s).

index::crlf: simplify test case

2018-12-04T01:01:52+00:00

crlf tests: use known-good data produced by git

2018-12-04T01:01:26+00:00

Given a variety of combinations of core.autocrlf, core.safecrlf settings
and attributes settings, test that we add files to index the same way
(regarding OIDs and fatal errors) as a known-good test resource created
by git.git.

Signed-off-by: Sven Strickroth