delta/libgit2.git/tests/object/commit/parse.c, branch ethomson/https_proxy github.com: libgit2/libgit2.git object_type: use new enumeration names 2018-12-01T11:54:57+00:00 Edward Thomson ethomson@edwardthomson.com 2018-11-28T14:26:57+00:00 168fe39bea3368972a8b1a33d5908e73bc790c18 Use the new object_type enumeration names within the codebase. 
Use the new object_type enumeration names within the codebase.
commit: fix reading out of bounds when parsing encoding 2018-10-25T10:52:54+00:00 Patrick Steinhardt ps@pks.im 2018-10-19T08:29:19+00:00 7655b2d89e8275853d9921dd903dcdad9b3d4a7b The commit message encoding is currently being parsed by the `git__prefixcmp` function. As this function does not accept a buffer length, it will happily skip over a buffer's end if it is not `NUL` terminated. Fix the issue by using `git__prefixncmp` instead. Add a test that verifies that we are unable to parse the encoding field if it's cut off by the supplied buffer length. 
The commit message encoding is currently being parsed by the
`git__prefixcmp` function. As this function does not accept a buffer
length, it will happily skip over a buffer's end if it is not `NUL`
terminated.

Fix the issue by using `git__prefixncmp` instead. Add a test that
verifies that we are unable to parse the encoding field if it's cut off
by the supplied buffer length.
tests: add tests that exercise commit parsing 2018-10-25T10:52:54+00:00 Patrick Steinhardt ps@pks.im 2018-10-25T10:01:18+00:00 c2e3d8ef699f310d353c2e378f12ea99ea4e0c67 We currently do not have any test suites dedicated to parsing commits from their raw representations. Add one based on `git_object__from_raw` to be able to test special cases more easily. 
We currently do not have any test suites dedicated to parsing commits
from their raw representations. Add one based on `git_object__from_raw`
to be able to test special cases more easily.