delta/libgit2.git/tests/pack/indexer.c, branch ethomson/https_proxy github.com: libgit2/libgit2.git indexer: use git_indexer_progress throughout 2019-02-22T11:25:14+00:00 Edward Thomson ethomson@edwardthomson.com 2019-02-21T10:33:30+00:00 a1ef995dc03379fb1f5151b5d98d16644218c95e Update internal usage of `git_transfer_progress` to `git_indexer_progreses`. 
Update internal usage of `git_transfer_progress` to
`git_indexer_progreses`.
git_error: use new names in internal APIs and usage 2019-01-22T22:30:35+00:00 Edward Thomson ethomson@edwardthomson.com 2018-12-27T19:47:34+00:00 f673e232afe22eb865cdc915e55a2df6493f0fbb Move to the `git_error` name in the internal API for error-related functions. 
Move to the `git_error` name in the internal API for error-related
functions.
object_type: use new enumeration names 2018-12-01T11:54:57+00:00 Edward Thomson ethomson@edwardthomson.com 2018-11-28T14:26:57+00:00 168fe39bea3368972a8b1a33d5908e73bc790c18 Use the new object_type enumeration names within the codebase. 
Use the new object_type enumeration names within the codebase.
tests: indexer: add test to exercise our connectivity checking 2018-06-22T07:52:12+00:00 Patrick Steinhardt ps@pks.im 2017-11-12T10:43:28+00:00 65a4b06eb173e3c3c1612cc1e45907d1d3b91337 The new connectivity tests are not currently being verified at all due to being turned off by default. Create two test cases for a pack file which fails our checks and one which suceeds. 
The new connectivity tests are not currently being verified at all due
to being turned off by default. Create two test cases for a pack file
which fails our checks and one which suceeds.
indexer: introduce options struct to `git_indexer_new` 2018-06-22T07:52:12+00:00 Patrick Steinhardt ps@pks.im 2017-11-12T10:31:48+00:00 c16556aaddffc1d663c6403747d793adc0819e0a We strive to keep an options structure to many functions to be able to extend options in the future without breaking the API. `git_indexer_new` doesn't have one right now, but we want to be able to add an option for enabling strict packfile verification. Add a new `git_indexer_options` structure and adjust callers to use that. 
We strive to keep an options structure to many functions to be able to
extend options in the future without breaking the API. `git_indexer_new`
doesn't have one right now, but we want to be able to add an option
for enabling strict packfile verification.

Add a new `git_indexer_options` structure and adjust callers to use
that.
Convert usage of `git_buf_free` to new `git_buf_dispose` 2018-06-10T17:34:37+00:00 Patrick Steinhardt ps@pks.im 2018-02-08T11:14:48+00:00 ecf4f33a4e327a91496f72816f9f02d923e5af05 






Fix unpack double free
2017-12-23T14:59:07+00:00

lhchavez
lhchavez@lhchavez.com

2017-12-23T14:59:07+00:00

c3514b0b82e90e660c996e81a525d42c025503ab

If an element has been cached, but then the call to
packfile_unpack_compressed() fails, the very next thing that happens is
that its data is freed and then the element is not removed from the
cache, which frees the data again.

This change sets obj->data to NULL to avoid the double-free. It also
stops trying to resolve deltas after two continuous failed rounds of
resolution, and adds a test for this.





If an element has been cached, but then the call to
packfile_unpack_compressed() fails, the very next thing that happens is
that its data is freed and then the element is not removed from the
cache, which frees the data again.

This change sets obj->data to NULL to avoid the double-free. It also
stops trying to resolve deltas after two continuous failed rounds of
resolution, and adds a test for this.







libFuzzer: Fix missing trailer crash
2017-12-08T14:37:46+00:00

lhchavez
lhchavez@lhchavez.com

2017-12-06T03:03:18+00:00

c8aaba2441315680c60a98c73d538922f5ccd33e

This change fixes an invalid memory access when the trailer is missing /
corrupt.

Found using libFuzzer.





This change fixes an invalid memory access when the trailer is missing /
corrupt.

Found using libFuzzer.







libFuzzer: Fix a git_packfile_stream leak
2017-12-06T04:32:16+00:00

lhchavez
lhchavez@lhchavez.com

2017-12-06T03:22:58+00:00

400caed3e0f93093d98619524184bf44937470c8

This change ensures that the git_packfile_stream object in
git_indexer_append() does not leak when the stream has errors.

Found using libFuzzer.





This change ensures that the git_packfile_stream object in
git_indexer_append() does not leak when the stream has errors.

Found using libFuzzer.







indexer: name pack files after trailer hash
2017-05-19T14:10:54+00:00

Chris Hescock
chescock@vistaprint.com

2017-01-11T15:39:59+00:00

c0e541556600d825779c950ab1a4ce93b6782b09

Upstream git.git has changed the way how packfiles are named.
Previously, they were using a hash of the contained object's OIDs, which
has then been changed to use the hash of the complete packfile instead.
See 1190a1acf (pack-objects: name pack files after trailer hash,
2013-12-05) in the git.git repository for more information on this
change.

This commit changes our logic to match the behavior of core git.





Upstream git.git has changed the way how packfiles are named.
Previously, they were using a hash of the contained object's OIDs, which
has then been changed to use the hash of the complete packfile instead.
See 1190a1acf (pack-objects: name pack files after trailer hash,
2013-12-05) in the git.git repository for more information on this
change.

This commit changes our logic to match the behavior of core git.