<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/libgit2.git/tests/submodule/modify.c, branch ethomson/diff_enum</title>
<subtitle>github.com: libgit2/libgit2.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/'/>
<entry>
<title>tests: submodule: verify setup of relative URLs</title>
<updated>2020-01-06T14:41:18+00:00</updated>
<author>
<name>Patrick Steinhardt</name>
<email>ps@pks.im</email>
</author>
<published>2020-01-06T14:41:18+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=11e8ee1ffea118926eb69633f86ca3c5a891bc57'/>
<id>11e8ee1ffea118926eb69633f86ca3c5a891bc57</id>
<content type='text'>
When setting up relative URLs for a submodule, then we resolve it to
the actual location and write that into ".git/config" instead of
writing the relative value. We do not yet have a test to nail down this
behaviour, which is now being added by this commit.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When setting up relative URLs for a submodule, then we resolve it to
the actual location and write that into ".git/config" instead of
writing the relative value. We do not yet have a test to nail down this
behaviour, which is now being added by this commit.
</pre>
</div>
</content>
</entry>
<entry>
<title>submodule: test unsetting config options</title>
<updated>2015-06-22T15:02:56+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-05-11T09:57:05+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=0496330004e64680903131cbae2ac27610517cd1'/>
<id>0496330004e64680903131cbae2ac27610517cd1</id>
<content type='text'>
In addition to mapping enums to strings in the configuration, we need to
know to delete the configuration option when given the "none" or "no"
option.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In addition to mapping enums to strings in the configuration, we need to
know to delete the configuration option when given the "none" or "no"
option.
</pre>
</div>
</content>
</entry>
<entry>
<title>submodule: test more accurately for non-existence</title>
<updated>2015-06-22T15:02:55+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-05-05T14:29:38+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=4536574acc85d8c78ceeac872eed6e4f79ef9aaa'/>
<id>4536574acc85d8c78ceeac872eed6e4f79ef9aaa</id>
<content type='text'>
The current code will always fail, but only because it's asking for a
string on a live config. Take a snapshot and make sure we fail with
ENOTFOUND instead of any old error.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The current code will always fail, but only because it's asking for a
string on a live config. Take a snapshot and make sure we fail with
ENOTFOUND instead of any old error.
</pre>
</div>
</content>
</entry>
<entry>
<title>submodule: get rid of `_save()`</title>
<updated>2015-06-22T15:02:55+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-05-05T07:25:17+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=961861fafad45c9eab29f523e51261ba78ab10be'/>
<id>961861fafad45c9eab29f523e51261ba78ab10be</id>
<content type='text'>
We no longer have any setters which affect an instance, so
`git_submodule_save()` is no longer relevant.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We no longer have any setters which affect an instance, so
`git_submodule_save()` is no longer relevant.
</pre>
</div>
</content>
</entry>
<entry>
<title>submodule: make `_set_url()` affect the configuration</title>
<updated>2015-06-22T15:02:55+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-05-05T07:22:35+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=d6073b30f38f95aa25b1545cccac38261b359de1'/>
<id>d6073b30f38f95aa25b1545cccac38261b359de1</id>
<content type='text'>
With this one, we can get rid of the edit_and_save test.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
With this one, we can get rid of the edit_and_save test.
</pre>
</div>
</content>
</entry>
<entry>
<title>submodule: make `_set_branch()` affect the configuration</title>
<updated>2015-06-22T15:02:55+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-05-05T07:13:52+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=486ba4cdd3d30c202d0c7ed202d6122a7e2b5164'/>
<id>486ba4cdd3d30c202d0c7ed202d6122a7e2b5164</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>submodule: make `_set_update_fetch_recurse_submodules()` affect the config</title>
<updated>2015-06-22T15:02:55+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-05-05T07:01:20+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=4e63642321bbea96b6a06ac28ac3c3e447f15df3'/>
<id>4e63642321bbea96b6a06ac28ac3c3e447f15df3</id>
<content type='text'>
Similarly to the other ones. In this test we copy over testing
`RECURSE_YES` which shows an error in our handling of the `YES` variant
which we may have to port to the rest.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Similarly to the other ones. In this test we copy over testing
`RECURSE_YES` which shows an error in our handling of the `YES` variant
which we may have to port to the rest.
</pre>
</div>
</content>
</entry>
<entry>
<title>submodule: make `_set_update()` affect the configuration</title>
<updated>2015-06-22T15:02:55+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-05-05T06:35:29+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=e8a39f8ed1a95b96415c719c826f0e5715432393'/>
<id>e8a39f8ed1a95b96415c719c826f0e5715432393</id>
<content type='text'>
Moving on with the removal of runtime-changing variables, the update
setting for a remote is whatever it was when it was looked up.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Moving on with the removal of runtime-changing variables, the update
setting for a remote is whatever it was when it was looked up.
</pre>
</div>
</content>
</entry>
<entry>
<title>submodule: make set_ignore() affect the configuration</title>
<updated>2015-06-22T15:02:55+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-05-04T14:22:56+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=5a9fc6c83c2fd12ce312d1042ec2c1e6abad4033'/>
<id>5a9fc6c83c2fd12ce312d1042ec2c1e6abad4033</id>
<content type='text'>
Instead of affecting a particular instance, make it change the
configuration.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Instead of affecting a particular instance, make it change the
configuration.
</pre>
</div>
</content>
</entry>
<entry>
<title>submodule: remove the per-repo cache</title>
<updated>2015-06-22T15:02:54+00:00</updated>
<author>
<name>Carlos Martín Nieto</name>
<email>cmn@dwim.me</email>
</author>
<published>2015-04-27T17:27:29+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/libgit2.git/commit/?id=dfda2f68ea9602a6b0d08e36bd48e6a4899b12ff'/>
<id>dfda2f68ea9602a6b0d08e36bd48e6a4899b12ff</id>
<content type='text'>
Having this cache and giving them out goes against our multithreading
guarantees and it makes it impossible to use submodules in a
multi-threaded environment, as any thread can ask for a refresh which
may reallocate some string in the submodule struct which we've accessed
in a different one via a getter.

This makes the submodules behave more like remotes, where each object is
created upon request and not shared except explicitly by the user. This
means that some tests won't pass yet, as they assume they can affect the
submodule objects in the cache and that will affect later operations.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Having this cache and giving them out goes against our multithreading
guarantees and it makes it impossible to use submodules in a
multi-threaded environment, as any thread can ask for a refresh which
may reallocate some string in the submodule struct which we've accessed
in a different one via a getter.

This makes the submodules behave more like remotes, where each object is
created upon request and not shared except explicitly by the user. This
means that some tests won't pass yet, as they assume they can affect the
submodule objects in the cache and that will affect later operations.
</pre>
</div>
</content>
</entry>
</feed>
