diff options
author | Patrick Steinhardt <ps@pks.im> | 2017-06-07 10:59:03 +0200 |
---|---|---|
committer | Patrick Steinhardt <ps@pks.im> | 2018-01-03 11:50:38 +0000 |
commit | 72c28ab011759dce113c2a0c7c36ebcd56bd6ddf (patch) | |
tree | 34322df49d0ee561d61e29f5d6b3638fa81bc018 | |
parent | 8999f6acc78810680f282db4257e842971b80cb4 (diff) | |
download | libgit2-72c28ab011759dce113c2a0c7c36ebcd56bd6ddf.tar.gz |
tests: status::worktree: indicate skipped tests on Win32
Some function bodies of tests which are not applicable to the Win32
platform are completely #ifdef'd out instead of calling `cl_skip()`.
This leaves us with no indication that these tests are not being
executed at all and may thus cause decreased scrutiny when investigating
skipped tests. Improve the situation by calling `cl_skip()` instead of
just doing nothing.
-rw-r--r-- | tests/checkout/tree.c | 2 | ||||
-rw-r--r-- | tests/iterator/workdir.c | 2 | ||||
-rw-r--r-- | tests/repo/open.c | 2 | ||||
-rw-r--r-- | tests/status/worktree.c | 4 |
4 files changed, 10 insertions, 0 deletions
diff --git a/tests/checkout/tree.c b/tests/checkout/tree.c index 56513eab7..a7e29b3db 100644 --- a/tests/checkout/tree.c +++ b/tests/checkout/tree.c @@ -1096,6 +1096,8 @@ void test_checkout_tree__filemode_preserved_in_workdir(void) cl_assert(!GIT_PERMS_IS_EXEC(read_filemode("a/b.txt"))); git_commit_free(commit); +#else + cl_skip(); #endif } diff --git a/tests/iterator/workdir.c b/tests/iterator/workdir.c index f33fd98f1..618006715 100644 --- a/tests/iterator/workdir.c +++ b/tests/iterator/workdir.c @@ -741,6 +741,8 @@ void test_iterator_workdir__skips_fifos_and_special_files(void) cl_assert_equal_i(GIT_ITEROVER, git_iterator_advance(&e, i)); git_iterator_free(i); +#else + cl_skip(); #endif } diff --git a/tests/repo/open.c b/tests/repo/open.c index 3239b6fec..ab36dd587 100644 --- a/tests/repo/open.c +++ b/tests/repo/open.c @@ -180,6 +180,8 @@ void test_repo_open__from_git_new_workdir(void) cl_assert_(git__suffixcmp(git_repository_workdir(repo2), "alternate/") == 0, git_repository_workdir(repo2)); git_repository_free(repo2); +#else + cl_skip(); #endif } diff --git a/tests/status/worktree.c b/tests/status/worktree.c index 1345dbfd2..79eece85a 100644 --- a/tests/status/worktree.c +++ b/tests/status/worktree.c @@ -1072,6 +1072,8 @@ void test_status_worktree__unreadable(void) cl_assert_equal_i(counts.expected_entry_count, counts.entry_count); cl_assert_equal_i(0, counts.wrong_status_flags_count); cl_assert_equal_i(0, counts.wrong_sorted_path); +#else + cl_skip(); #endif } @@ -1106,6 +1108,8 @@ void test_status_worktree__unreadable_not_included(void) cl_assert_equal_i(counts.expected_entry_count, counts.entry_count); cl_assert_equal_i(0, counts.wrong_status_flags_count); cl_assert_equal_i(0, counts.wrong_sorted_path); +#else + cl_skip(); #endif } |