diff options
| author | Andreas Henriksson <andreas@fatal.se> | 2016-12-17 17:33:13 +0100 |
|---|---|---|
| committer | Andreas Henriksson <andreas.henriksson@endian.se> | 2016-12-17 17:40:49 +0100 |
| commit | 23c9ff8632d8ae90d211601d3254ab7f4d35e853 (patch) | |
| tree | 461eb2532145f0639ae825ffc9c8d6c6f01306ea | |
| parent | c655def1174f814c2adcafff7cecec4d47dc5830 (diff) | |
| download | libgit2-23c9ff8632d8ae90d211601d3254ab7f4d35e853.tar.gz | |
Fix off-by-one problems in git_signature__parse
Etc/GMT-14 aka UTC+14:00 is a thing....
https://en.wikipedia.org/wiki/UTC%2B14:00
Also allow offsets on the last minute (59).
Addresses: https://bugs.debian.org/841532
Fixes: #3970
| -rw-r--r-- | src/signature.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/signature.c b/src/signature.c index dcc379717..22cba7ef3 100644 --- a/src/signature.c +++ b/src/signature.c @@ -251,7 +251,7 @@ int git_signature__parse(git_signature *sig, const char **buffer_out, * only store timezone if it's not overflowing; * see http://www.worldtimezone.com/faq.html */ - if (hours < 14 && mins < 59) { + if (hours <= 14 && mins <= 59) { sig->when.offset = (hours * 60) + mins; if (tz_start[0] == '-') sig->when.offset = -sig->when.offset; |