summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarlos Martín Nieto <cmn@dwim.me>2016-10-05 12:55:53 +0200
committerCarlos Martín Nieto <cmn@dwim.me>2016-10-06 11:04:55 +0200
commit82d4c0e6b841ae0e466bd97ab1faec0920a6b7a2 (patch)
treec3d52eb09658ab90866824d6dd41e93926c7738e
parentea1ceb7f554da276ffb0fe18c6ca4a0233845d55 (diff)
downloadlibgit2-82d4c0e6b841ae0e466bd97ab1faec0920a6b7a2.tar.gz
revwalk: update the description for the default sorting
It changed from implementation-defined to git's default sorting, as there are systems (e.g. rebase) which depend on this order. Also specify more explicitly how you can get git's "date-order".
-rw-r--r--include/git2/revwalk.h10
-rw-r--r--src/revwalk.c4
2 files changed, 4 insertions, 10 deletions
diff --git a/include/git2/revwalk.h b/include/git2/revwalk.h
index 2cc00536e..d9376ceea 100644
--- a/include/git2/revwalk.h
+++ b/include/git2/revwalk.h
@@ -25,17 +25,15 @@ GIT_BEGIN_DECL
*/
typedef enum {
/**
- * Sort the repository contents in no particular ordering;
- * this sorting is arbitrary, implementation-specific
- * and subject to change at any time.
+ * Sort the output with the same default time-order method from git.
* This is the default sorting for new walkers.
*/
GIT_SORT_NONE = 0,
/**
- * Sort the repository contents in topological order
- * (parents before children); this sorting mode
- * can be combined with time sorting.
+ * Sort the repository contents in topological order (parents before
+ * children); this sorting mode can be combined with time sorting to
+ * produce git's "time-order".
*/
GIT_SORT_TOPOLOGICAL = 1 << 0,
diff --git a/src/revwalk.c b/src/revwalk.c
index 80f5bdfdf..4753a3723 100644
--- a/src/revwalk.c
+++ b/src/revwalk.c
@@ -555,10 +555,6 @@ static int prepare_walk(git_revwalk *walk)
}
}
- for (list = commits; list; list = list->next) {
- printf("%s: commit %s\n", __func__, git_oid_tostr_s(&list->item->oid));
- }
-
if ((error = limit_list(&commits, walk, commits)) < 0)
return error;