diff options
author | Edward Thomson <ethomson@edwardthomson.com> | 2019-01-08 14:35:39 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-01-08 14:35:39 +0000 |
commit | 19bca3d33c863dc95ed322b9f8c990808d9af80f (patch) | |
tree | d447d610b6e5814842641f1cd4f2647a17db9484 | |
parent | fba70a9d5f1fa433968a3dfd51e3153c8eebe834 (diff) | |
parent | a74f4fb9d27875e46e330e66b0e40fff92b121d9 (diff) | |
download | libgit2-19bca3d33c863dc95ed322b9f8c990808d9af80f.tar.gz |
Merge pull request #4922 from tiennou/fix/coverity-cids
Coverity fixes
-rw-r--r-- | script/user_model.c | 23 | ||||
-rw-r--r-- | src/config.c | 2 | ||||
-rw-r--r-- | src/diff_tform.c | 2 | ||||
-rw-r--r-- | src/refs.c | 2 | ||||
-rw-r--r-- | src/submodule.c | 2 | ||||
-rw-r--r-- | tests/index/crlf.c | 2 |
6 files changed, 32 insertions, 1 deletions
diff --git a/script/user_model.c b/script/user_model.c index a933d735c..49425272e 100644 --- a/script/user_model.c +++ b/script/user_model.c @@ -73,3 +73,26 @@ int git_buf_set(git_buf *buf, const void *data, size_t len) buf->size = len + 1; return 0; } + +void clar__fail( + const char *file, + int line, + const char *error, + const char *description, + int should_abort) +{ + if (should_abort) + __coverity_panic__(); +} + +void clar__assert( + int condition, + const char *file, + int line, + const char *error, + const char *description, + int should_abort) +{ + if (!condition && should_abort) + __coverity_panic__(); +} diff --git a/src/config.c b/src/config.c index 569b69f6e..30d97306c 100644 --- a/src/config.c +++ b/src/config.c @@ -513,6 +513,8 @@ int git_config_backend_foreach_match( regex_t regex; int error = 0; + assert(backend && cb); + if (regexp != NULL) { if ((error = p_regcomp(®ex, regexp, REG_EXTENDED)) != 0) { giterr_set_regex(®ex, error); diff --git a/src/diff_tform.c b/src/diff_tform.c index 8c5abbf47..3a8924d0b 100644 --- a/src/diff_tform.c +++ b/src/diff_tform.c @@ -816,6 +816,8 @@ int git_diff_find_similar( diff_find_match *best_match; git_diff_file swap; + assert(diff); + if ((error = normalize_find_opts(diff, &opts, given_opts)) < 0) return error; diff --git a/src/refs.c b/src/refs.c index 50afb2609..85599da6e 100644 --- a/src/refs.c +++ b/src/refs.c @@ -709,6 +709,8 @@ int git_reference_rename( git_signature *who; int error; + assert(out && ref); + if ((error = git_reference__log_signature(&who, ref->db->repo)) < 0) return error; diff --git a/src/submodule.c b/src/submodule.c index f52b65876..c468a9618 100644 --- a/src/submodule.c +++ b/src/submodule.c @@ -208,7 +208,7 @@ static int load_submodule_names(git_strmap **out, git_repository *repo, git_conf if ((error = git_config_iterator_glob_new(&iter, cfg, key)) < 0) goto out; - while (git_config_next(&entry, iter) == 0) { + while ((error = git_config_next(&entry, iter)) == 0) { const char *fdot, *ldot; fdot = strchr(entry->name, '.'); ldot = strrchr(entry->name, '.'); diff --git a/tests/index/crlf.c b/tests/index/crlf.c index 31050f8f8..ddf01fed1 100644 --- a/tests/index/crlf.c +++ b/tests/index/crlf.c @@ -353,6 +353,7 @@ void test_index_crlf__safecrlf_true_autocrlf_input_text_auto_attr(void) cl_git_pass(git_index_add_bypath(g_index, "newfile.txt")); entry = git_index_get_bypath(g_index, "newfile.txt", 0); + cl_assert(entry); cl_git_pass(git_oid_fromstr(&oid, FILE_OID_LF)); cl_assert_equal_oid(&oid, &entry->id); @@ -373,6 +374,7 @@ void test_index_crlf__safecrlf_true_autocrlf_input_text__no_attr(void) cl_git_pass(git_index_add_bypath(g_index, "newfile.txt")); entry = git_index_get_bypath(g_index, "newfile.txt", 0); + cl_assert(entry); cl_git_pass(git_oid_fromstr(&oid, FILE_OID_LF)); cl_assert_equal_oid(&oid, &entry->id); |