summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Steinhardt <ps@pks.im>2020-06-08 12:42:59 +0200
committerPatrick Steinhardt <ps@pks.im>2020-06-09 14:57:06 +0200
commit03c4f86c24df22aaf6a2ac61b662ddb8229dee43 (patch)
tree7f1563209a18a76afe655c13108a3f56be9c3e6f
parentfd1f09408cc7905e0d607c1adb5b41c1d0073420 (diff)
downloadlibgit2-03c4f86c24df22aaf6a2ac61b662ddb8229dee43.tar.gz
cmake: enable warnings for missing function declarations
Over time, we have accumulated quite a lot of functions with missing prototypes, missing `static` keywords or which were completely unused. It's easy to miss these mistakes, but luckily GCC and Clang both have the `-Wmissing-declarations` warning. Enabling this will cause them to emit warnings for every not-static function that doesn't have a previous declaration. This is a very sane thing to enable, and with the preceding commits all these new warnings have been fixed. So let's always enable this warning so we won't introduce new instances of them.
-rw-r--r--src/CMakeLists.txt2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 1fb1c536a..481707c7a 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -21,6 +21,8 @@ SET(LIBGIT2_INCLUDES
SET(LIBGIT2_SYSTEM_INCLUDES "")
SET(LIBGIT2_LIBS "")
+enable_warnings(missing-declarations)
+
# Enable tracing
IF(ENABLE_TRACE)
SET(GIT_TRACE 1)