diff options
| author | Patrick Steinhardt <ps@pks.im> | 2018-08-24 11:01:39 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-08-24 11:01:39 +0200 |
| commit | 9a193102d011633801855483a0c10af65a9cbf6d (patch) | |
| tree | b7bdb3f82a2c63924e0e510e24e0a6291cf29162 | |
| parent | fd7ab1d7d9db54c32bfe3664316a13ee63ec341f (diff) | |
| parent | 1c949ce1483ca22a29e8f523360999cbbe411a50 (diff) | |
| download | libgit2-9a193102d011633801855483a0c10af65a9cbf6d.tar.gz | |
Merge pull request #4774 from tiennou/fix/clang-analyzer
Coverity flavored clang analyzer fixes
| -rw-r--r-- | src/mailmap.c | 2 | ||||
| -rw-r--r-- | src/remote.c | 4 | ||||
| -rw-r--r-- | src/revwalk.c | 2 | ||||
| -rw-r--r-- | src/transports/http.c | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/src/mailmap.c b/src/mailmap.c index fe4d452d5..1f725b30d 100644 --- a/src/mailmap.c +++ b/src/mailmap.c @@ -225,7 +225,7 @@ int git_mailmap_add_entry( static int mailmap_add_buffer(git_mailmap *mm, const char *buf, size_t len) { - int error; + int error = 0; git_parse_ctx ctx; /* Scratch buffers containing the real parsed names & emails */ diff --git a/src/remote.c b/src/remote.c index ca73ede5f..9c0e88ac0 100644 --- a/src/remote.c +++ b/src/remote.c @@ -428,7 +428,7 @@ static int get_optional_config( int git_remote_lookup(git_remote **out, git_repository *repo, const char *name) { - git_remote *remote; + git_remote *remote = NULL; git_buf buf = GIT_BUF_INIT; const char *val; int error = 0; @@ -510,7 +510,7 @@ int git_remote_lookup(git_remote **out, git_repository *repo, const char *name) if ((error = get_optional_config(NULL, config, &buf, refspec_cb, &data)) < 0) goto cleanup; - if (download_tags_value(remote, config) < 0) + if ((error = download_tags_value(remote, config)) < 0) goto cleanup; if ((error = lookup_remote_prune_config(remote, config, name)) < 0) diff --git a/src/revwalk.c b/src/revwalk.c index be647af3a..da84a4471 100644 --- a/src/revwalk.c +++ b/src/revwalk.c @@ -550,7 +550,7 @@ cleanup: static int prepare_walk(git_revwalk *walk) { - int error; + int error = 0; git_commit_list *list, *commits = NULL; git_commit_list_node *next; diff --git a/src/transports/http.c b/src/transports/http.c index ea3e57a49..bc3ab18e2 100644 --- a/src/transports/http.c +++ b/src/transports/http.c @@ -142,7 +142,7 @@ static int auth_context_match( } if (!scheme) - return 0; + return -1; /* See if authentication has already started for this scheme */ git_vector_foreach(&t->auth_contexts, i, c) { |