diff options
| author | Patrick Steinhardt <ps@pks.im> | 2019-06-07 10:13:34 +0200 |
|---|---|---|
| committer | Patrick Steinhardt <ps@pks.im> | 2019-06-13 11:03:46 +0200 |
| commit | 3b517351d06d37d04d1ace80be04c84d225fa793 (patch) | |
| tree | a47f994868af3c1d9322befd73653ccc52cb6ba7 | |
| parent | b3b6a39d928cf4ecda54468cc5029013363654d7 (diff) | |
| download | libgit2-3b517351d06d37d04d1ace80be04c84d225fa793.tar.gz | |
attr_file: remove invalid TODO comment
In our attributes pattern parsing code, we have a comment that
states we might have to convert '\' characters to '/' to have
proper POSIX paths. But in fact, '\' characters are valid inside
the string and act as escape mechanism for various characters,
which is why we never want to convert those to POSIX directory
separators. Furthermore, gitignore patterns are specified to only
treat '/' as directory separators.
Remove the comment to avoid future confusion.
| -rw-r--r-- | src/attr_file.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/attr_file.c b/src/attr_file.c index 08b6c3f29..f01a743d2 100644 --- a/src/attr_file.c +++ b/src/attr_file.c @@ -743,7 +743,6 @@ int git_attr_fnmatch__parse( } else { /* strip '\' that might have been used for internal whitespace */ spec->length = unescape_spaces(spec->pattern); - /* TODO: convert remaining '\' into '/' for POSIX ??? */ } return 0; |