diff options
author | Edward Thomson <ethomson@github.com> | 2016-04-11 11:50:11 -0400 |
---|---|---|
committer | Edward Thomson <ethomson@github.com> | 2016-04-11 11:50:11 -0400 |
commit | d22a8b95830f3cb3dbc6cfaec65dd1b5a5d1444a (patch) | |
tree | 6d8b69334fff33821e1384bcb7185b3bab9ed0ce | |
parent | 6d22ef7a517191047bb0728a2180460cf8ae0c99 (diff) | |
download | libgit2-d22a8b95830f3cb3dbc6cfaec65dd1b5a5d1444a.tar.gz |
refs::create: strict object creation on by default
When we turned strict object creation validation on by default, we
forgot to inform the refs::create tests of this. They, in fact,
believed that strict object creation was off by default. As a result,
their cleanup function went and turned strict object creation off for
the remaining tests.
-rw-r--r-- | tests/refs/create.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/tests/refs/create.c b/tests/refs/create.c index b96d0c90a..6d5a5f1f6 100644 --- a/tests/refs/create.c +++ b/tests/refs/create.c @@ -19,7 +19,7 @@ void test_refs_create__cleanup(void) { cl_git_sandbox_cleanup(); - cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 0)); + cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 1)); } void test_refs_create__symbolic(void) @@ -122,7 +122,7 @@ void test_refs_create__oid(void) } /* Can by default create a reference that targets at an unknown id */ -void test_refs_create__oid_unknown_succeeds_by_default(void) +void test_refs_create__oid_unknown_succeeds_without_strict(void) { git_reference *new_reference, *looked_up_ref; git_oid id; @@ -131,6 +131,8 @@ void test_refs_create__oid_unknown_succeeds_by_default(void) git_oid_fromstr(&id, "deadbeef3f795b2b4353bcce3a527ad0a4f7f644"); + cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 0)); + /* Create and write the new object id reference */ cl_git_pass(git_reference_create(&new_reference, g_repo, new_head, &id, 0, NULL)); git_reference_free(new_reference); @@ -141,7 +143,7 @@ void test_refs_create__oid_unknown_succeeds_by_default(void) } /* Strict object enforcement enforces valid object id */ -void test_refs_create__oid_unknown_fails_strict_mode(void) +void test_refs_create__oid_unknown_fails_by_default(void) { git_reference *new_reference, *looked_up_ref; git_oid id; @@ -150,8 +152,6 @@ void test_refs_create__oid_unknown_fails_strict_mode(void) git_oid_fromstr(&id, "deadbeef3f795b2b4353bcce3a527ad0a4f7f644"); - cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_OBJECT_CREATION, 1)); - /* Create and write the new object id reference */ cl_git_fail(git_reference_create(&new_reference, g_repo, new_head, &id, 0, NULL)); |