diff options
author | Edward Thomson <ethomson@edwardthomson.com> | 2023-02-14 15:23:11 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-02-14 15:23:11 +0000 |
commit | 0362ecd6f1c8f0a1c798634deee490ba572b7b9a (patch) | |
tree | f2b9d7e4caeeb8f9784e2689385d9a3d430b8654 | |
parent | 3b43c9d33597b11bc7fdf3bcfe3b21bfeff95e15 (diff) | |
parent | b57221e82919b798983ea0d3c3fd1a5de9170809 (diff) | |
download | libgit2-0362ecd6f1c8f0a1c798634deee490ba572b7b9a.tar.gz |
Merge pull request #6423 from cavaquinho/fix/6422-revwalk_push_glob-dangling-ref
#6422: handle dangling symbolic refs gracefully
-rw-r--r-- | src/libgit2/revwalk.c | 6 | ||||
-rw-r--r-- | tests/libgit2/revwalk/basic.c | 17 |
2 files changed, 22 insertions, 1 deletions
diff --git a/src/libgit2/revwalk.c b/src/libgit2/revwalk.c index 553e0497a..3269d9279 100644 --- a/src/libgit2/revwalk.c +++ b/src/libgit2/revwalk.c @@ -121,8 +121,12 @@ int git_revwalk__push_ref(git_revwalk *walk, const char *refname, const git_revw { git_oid oid; - if (git_reference_name_to_id(&oid, walk->repo, refname) < 0) + int error = git_reference_name_to_id(&oid, walk->repo, refname); + if (opts->from_glob && (error == GIT_ENOTFOUND || error == GIT_EINVALIDSPEC || error == GIT_EPEEL)) { + return 0; + } else if (error < 0) { return -1; + } return git_revwalk__push_commit(walk, &oid, opts); } diff --git a/tests/libgit2/revwalk/basic.c b/tests/libgit2/revwalk/basic.c index 62a57aaa3..41090a1da 100644 --- a/tests/libgit2/revwalk/basic.c +++ b/tests/libgit2/revwalk/basic.c @@ -180,6 +180,23 @@ void test_revwalk_basic__glob_heads_with_invalid(void) cl_assert_equal_i(20, i); } +void test_revwalk_basic__glob_invalid_symbolic_ref(void) +{ + int i; + git_oid oid; + + revwalk_basic_setup_walk("testrepo"); + + cl_git_mkfile("testrepo/.git/refs/heads/broken-sym-ref", "ref: refs/heads/does-not-exist"); + cl_git_pass(git_revwalk_push_glob(_walk, "heads")); + + for (i = 0; !git_revwalk_next(&oid, _walk); ++i) + /* walking */; + + /* git log --branches --oneline | wc -l => 16 */ + cl_assert_equal_i(20, i); +} + void test_revwalk_basic__push_head(void) { int i = 0; |