diff options
| author | Etienne Samson <samson.etienne@gmail.com> | 2018-06-19 20:18:26 +0200 |
|---|---|---|
| committer | Etienne Samson <samson.etienne@gmail.com> | 2018-07-06 22:13:09 +0200 |
| commit | 36a5b557f146affcc627e6f762b2ab722e2796ce (patch) | |
| tree | 2a9a59b01bb978b44e101973fb44be32c9f5308f | |
| parent | 17bd3b964f8acb1244a3910365ac7967ff3c758c (diff) | |
| download | libgit2-36a5b557f146affcc627e6f762b2ab722e2796ce.tar.gz | |
submodule: don't leak memory when failing to insert the names
Reported by Coverity, CID 1393237
| -rw-r--r-- | src/submodule.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/submodule.c b/src/submodule.c index d0c7d04e6..3cbddfa3e 100644 --- a/src/submodule.c +++ b/src/submodule.c @@ -260,7 +260,8 @@ static int load_submodule_names(git_strmap **out, git_repository *repo, git_conf git_strmap_insert(names, entry->value, git_buf_detach(&buf), &rval); if (rval < 0) { giterr_set(GITERR_NOMEMORY, "error inserting submodule into hash table"); - return -1; + error = -1; + goto out; } } if (error == GIT_ITEROVER) |