summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authornulltoken <emeric.fermas@gmail.com>2011-03-03 19:41:27 +0200
committerVicent Marti <tanoku@gmail.com>2011-03-03 20:23:51 +0200
commite2d426227f3a03ef6de6715d3c471c1490e4bd4c (patch)
treec4b58ab7b5dccb2997b4f0f3218b2f83c190ad36
parentde05ff6c788dda6e61f4567e6c4dea4f59a8f949 (diff)
downloadlibgit2-e2d426227f3a03ef6de6715d3c471c1490e4bd4c.tar.gz
Fix reference renaming to prevent duplicated names
-rw-r--r--src/refs.c10
1 files changed, 10 insertions, 0 deletions
diff --git a/src/refs.c b/src/refs.c
index c532d513b..674839b8b 100644
--- a/src/refs.c
+++ b/src/refs.c
@@ -1124,9 +1124,19 @@ int git_reference_rename(git_reference *ref, const char *new_name)
int error;
char *old_name;
char old_path[GIT_PATH_MAX], new_path[GIT_PATH_MAX];
+ git_reference *looked_up_ref;
assert(ref);
+ /* Ensure we're not going to overwrite an existing reference */
+ error = git_repository_lookup_ref(&looked_up_ref, ref->owner, new_name);
+ if (error == GIT_SUCCESS)
+ return GIT_EINVALIDREFNAME;
+
+ if (error != GIT_ENOTFOUND)
+ return error;
+
+
old_name = ref->name;
ref->name = git__strdup(new_name);