diff options
| author | Etienne Samson <samson.etienne@gmail.com> | 2018-10-24 01:21:21 +0200 |
|---|---|---|
| committer | Edward Thomson <ethomson@edwardthomson.com> | 2019-01-18 22:39:06 +0000 |
| commit | a4b332e8775a2e4fedf24c143b10f087ddf53d02 (patch) | |
| tree | 60c574f2aa828e7b5e7a8b2262d5d00c68045cce | |
| parent | 313440c394589af4387daa71b31821ed9b7f4462 (diff) | |
| download | libgit2-a4b332e8775a2e4fedf24c143b10f087ddf53d02.tar.gz | |
submodule: grab the error while loading from config
Previously, an error in `git_config_next` would be mistaken as a
successful load, because the previous call would have succeeded.
Coverity saw the subsequent check for a completed iteration as dead, so
let's make it useful again.
CID 1391374
| -rw-r--r-- | src/submodule.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/submodule.c b/src/submodule.c index 06b7de585..2bfc46880 100644 --- a/src/submodule.c +++ b/src/submodule.c @@ -181,7 +181,7 @@ static int load_submodule_names(git_strmap *out, git_repository *repo, git_confi if ((error = git_config_iterator_glob_new(&iter, cfg, key)) < 0) return error; - while (git_config_next(&entry, iter) == 0) { + while ((error = git_config_next(&entry, iter)) == 0) { const char *fdot, *ldot; fdot = strchr(entry->name, '.'); ldot = strrchr(entry->name, '.'); |