summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEtienne Samson <samson.etienne@gmail.com>2018-08-21 01:12:11 +0200
committerPatrick Steinhardt <ps@pks.im>2018-10-26 14:58:51 +0200
commitc0e038a29b28b43e5bf5e4c246a8fa5fa2bb2cd9 (patch)
tree2f0ff7c46d5441f76ae854f34d6e5418b4d3d2fb
parentef7d7defd6fdd504f2c34f66080e31a440a0fdfd (diff)
downloadlibgit2-c0e038a29b28b43e5bf5e4c246a8fa5fa2bb2cd9.tar.gz
revwalk: The left operand of '<' is a garbage value
At line 594, we do this : if (error < 0) return error; but if nothing was pushed in a GIT_SORT_TIME revwalk, we'd return uninitialized stack data. (cherry picked from commit aa8cb5866f1eabd92c8c08f7a8610d42df07375f)
-rw-r--r--src/revwalk.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/revwalk.c b/src/revwalk.c
index eb228a522..290313a3b 100644
--- a/src/revwalk.c
+++ b/src/revwalk.c
@@ -522,7 +522,7 @@ cleanup:
static int prepare_walk(git_revwalk *walk)
{
- int error;
+ int error = 0;
git_commit_list *list, *commits = NULL;
git_commit_list_node *next;