diff options
author | Edward Thomson <ethomson@edwardthomson.com> | 2022-04-11 17:07:20 +0100 |
---|---|---|
committer | Edward Thomson <ethomson@edwardthomson.com> | 2022-04-12 09:06:01 -0400 |
commit | 284b2bf1f453b267aa4cff4d84aa391254ba0606 (patch) | |
tree | b756f154df53350d54503f835dd75a7de48fa6c3 | |
parent | ca27240aa03f69cde088325ba3a3249466832cfe (diff) | |
download | libgit2-284b2bf1f453b267aa4cff4d84aa391254ba0606.tar.gz |
repo: test configuration ownership validation
Test that we prevent opening directories that are not owned by
ourselves.
-rw-r--r-- | tests/repo/config.c | 1 | ||||
-rw-r--r-- | tests/repo/open.c | 35 |
2 files changed, 35 insertions, 1 deletions
diff --git a/tests/repo/config.c b/tests/repo/config.c index ee7e43dff..37f6b521d 100644 --- a/tests/repo/config.c +++ b/tests/repo/config.c @@ -28,7 +28,6 @@ void test_repo_config__cleanup(void) cl_assert(!git_fs_path_isdir("alternate")); cl_fixture_cleanup("empty_standard_repo"); - } void test_repo_config__can_open_global_when_there_is_no_file(void) diff --git a/tests/repo/open.c b/tests/repo/open.c index f7ed2c373..fa6e36b8f 100644 --- a/tests/repo/open.c +++ b/tests/repo/open.c @@ -7,9 +7,12 @@ void test_repo_open__cleanup(void) { cl_git_sandbox_cleanup(); + cl_fixture_cleanup("empty_standard_repo"); if (git_fs_path_isdir("alternate")) git_futils_rmdir_r("alternate", NULL, GIT_RMDIR_REMOVE_FILES); + + git_fs_path__set_owner(GIT_FS_PATH_MOCK_OWNER_NONE); } void test_repo_open__bare_empty_repo(void) @@ -453,3 +456,35 @@ void test_repo_open__force_bare(void) git_repository_free(barerepo); } +void test_repo_open__validates_dir_ownership(void) +{ + git_repository *repo; + + cl_fixture_sandbox("empty_standard_repo"); + cl_git_pass(cl_rename("empty_standard_repo/.gitted", "empty_standard_repo/.git")); + + /* When the current user owns the repo config, that's acceptable */ + git_fs_path__set_owner(GIT_FS_PATH_MOCK_OWNER_CURRENT_USER); + cl_git_pass(git_repository_open(&repo, "empty_standard_repo")); + git_repository_free(repo); + + /* When the system user owns the repo config, fail */ + git_fs_path__set_owner(GIT_FS_PATH_MOCK_OWNER_SYSTEM); + cl_git_fail(git_repository_open(&repo, "empty_standard_repo")); + + /* When an unknown user owns the repo config, fail */ + git_fs_path__set_owner(GIT_FS_PATH_MOCK_OWNER_OTHER); + cl_git_fail(git_repository_open(&repo, "empty_standard_repo")); +} + +void test_repo_open__can_allowlist_dirs_with_problematic_ownership(void) +{ + git_repository *repo; + + cl_fixture_sandbox("empty_standard_repo"); + cl_git_pass(cl_rename("empty_standard_repo/.gitted", "empty_standard_repo/.git")); + + git_fs_path__set_owner(GIT_FS_PATH_MOCK_OWNER_OTHER); + cl_git_fail(git_repository_open(&repo, "empty_standard_repo")); + +} |