diff options
author | Russell Belfer <rb@github.com> | 2012-08-03 17:08:01 -0700 |
---|---|---|
committer | Russell Belfer <rb@github.com> | 2012-08-03 17:08:01 -0700 |
commit | 5dca201072724e4230141796d7c9f8836a277de8 (patch) | |
tree | 7eb6b8f3e08c8abc608ee43c0ddc32d4d043a2c6 /src/attr.c | |
parent | 2031760c626711cc69b4d63ac9798ff333583ca0 (diff) | |
download | libgit2-5dca201072724e4230141796d7c9f8836a277de8.tar.gz |
Update iterators for consistency across library
This updates all the `foreach()` type functions across the library
that take callbacks from the user to have a consistent behavior.
The rules are:
* A callback terminates the loop by returning any non-zero value
* Once the callback returns non-zero, it will not be called again
(i.e. the loop stops all iteration regardless of state)
* If the callback returns non-zero, the parent fn returns GIT_EUSER
* Although the parent returns GIT_EUSER, no error will be set in
the library and `giterr_last()` will return NULL if called.
This commit makes those changes across the library and adds tests
for most of the iteration APIs to make sure that they follow the
above rules.
Diffstat (limited to 'src/attr.c')
-rw-r--r-- | src/attr.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/attr.c b/src/attr.c index 6fbd005d5..c58a1f045 100644 --- a/src/attr.c +++ b/src/attr.c @@ -163,11 +163,14 @@ int git_attr_foreach( continue; git_strmap_insert(seen, assign->name, assign, error); - if (error >= 0) - error = callback(assign->name, assign->value, payload); + if (error < 0) + goto cleanup; - if (error != 0) + error = callback(assign->name, assign->value, payload); + if (error) { + error = GIT_EUSER; goto cleanup; + } } } } |