diff options
| author | Carlos Martín Nieto <cmn@dwim.me> | 2014-06-04 17:31:42 +0200 |
|---|---|---|
| committer | Carlos Martín Nieto <cmn@dwim.me> | 2014-06-04 17:31:42 +0200 |
| commit | 57cb1179e5c9c8f5c27c9115f13f1cae5d0f87a0 (patch) | |
| tree | 67871086b1437dcd410979b423cd3ba140ab9257 /src/branch.c | |
| parent | 90befde4a1938641dfdb9a7bdb9f361d1de5c26f (diff) | |
| download | libgit2-cmn/config-default-snapshot.tar.gz | |
Make the default repository config getter return a snapshotcmn/config-default-snapshot
You should always use a snapshot, with the sole exception of writing to
the configuration.
Any reads that are not against a snapshot have race conditions, both in
terms of returned values as well as dangling pointers.
Diffstat (limited to 'src/branch.c')
| -rw-r--r-- | src/branch.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/branch.c b/src/branch.c index 52760853b..808f6998e 100644 --- a/src/branch.c +++ b/src/branch.c @@ -341,7 +341,7 @@ int git_branch_upstream_name( if (!git_reference__is_branch(refname)) return not_a_local_branch(refname); - if ((error = git_repository_config_snapshot(&config, repo)) < 0) + if ((error = git_repository_config(&config, repo)) < 0) return error; if ((error = retrieve_upstream_configuration( |