diff options
| author | Russell Belfer <arrbee@arrbee.com> | 2012-02-29 12:04:59 -0800 |
|---|---|---|
| committer | Russell Belfer <arrbee@arrbee.com> | 2012-03-02 15:51:55 -0800 |
| commit | 854eccbb2d86c2910f9d98dc52f9ebd0e37c262a (patch) | |
| tree | b22048a02480598477cde9c41fc16d3967226d6b /src/config_file.c | |
| parent | 74fa4bfae37e9d7c9e35550c881b114d7a83c4fa (diff) | |
| download | libgit2-854eccbb2d86c2910f9d98dc52f9ebd0e37c262a.tar.gz | |
Clean up GIT_UNUSED macros on all platforms
It turns out that commit 31e9cfc4cbcaf1b38cdd3dbe3282a8f57e5366a5
did not fix the GIT_USUSED behavior on all platforms. This commit
walks through and really cleans things up more thoroughly, getting
rid of the unnecessary stuff.
To remove the use of some GIT_UNUSED, I ended up adding a couple
of new iterators for hashtables that allow you to iterator just
over keys or just over values.
In making this change, I found a bug in the clar tests (where we
were doing *count++ but meant to do (*count)++ to increment the
value). I fixed that but then found the test failing because it
was not really using an empty repo. So, I took some of the code
that I wrote for iterator testing and moved it to clar_helpers.c,
then made use of that to make it easier to open fixtures on a
per test basis even within a single test file.
Diffstat (limited to 'src/config_file.c')
| -rw-r--r-- | src/config_file.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/config_file.c b/src/config_file.c index ce76493c7..3c7c593ec 100644 --- a/src/config_file.c +++ b/src/config_file.c @@ -125,13 +125,12 @@ static int normalize_name(const char *in, char **out) static void free_vars(git_hashtable *values) { - const char *GIT_UNUSED(_unused) = NULL; cvar_t *var = NULL; if (values == NULL) return; - GIT_HASHTABLE_FOREACH(values, _unused, var, + GIT_HASHTABLE_FOREACH_VALUE(values, var, do { cvar_t *next = CVAR_LIST_NEXT(var); cvar_free(var); |