Drop git_patch_to_str

It's hard or even impossible to correctly free the string buffer
allocated by git_patch_to_str in some circumstances. Drop the function
so people have to use git_patch_to_buf instead - git_buf has a dedicated
destructor.

1 files changed, 0 insertions, 18 deletions

diff --git a/src/diff_print.c b/src/diff_print.c
index 0ab21d033..dd31d1ffa 100644
--- a/src/diff_print.c
+++ b/src/diff_print.c
@@ -459,21 +459,3 @@ int git_patch_to_buf(
 {
 	return git_patch_print(patch, diff_print_to_buffer_cb, out);
 }
-
-/* print a git_patch to a char* */
-int git_patch_to_str(
-	char **string,
-	git_patch *patch)
-{
-	int error;
-	git_buf output = GIT_BUF_INIT;
-
-	if (!(error = git_patch_to_buf(&output, patch)))
-		*string = git_buf_detach(&output);
-	else {
-		git_buf_free(&output);
-		*string = NULL;
-	}
-
-	return error;
-}