diff options
| author | Vicent Marti <tanoku@gmail.com> | 2011-11-25 08:16:26 +0100 |
|---|---|---|
| committer | Vicent Marti <tanoku@gmail.com> | 2011-11-26 08:37:08 +0100 |
| commit | 9462c471435b4de74848408bebe41d770dc49a50 (patch) | |
| tree | aac5e696d1b3e7b4cba64082b28255e5c4593b66 /src/fetch.c | |
| parent | 880b6f0c22153db164ecb3a18c362ba8337365d3 (diff) | |
| download | libgit2-9462c471435b4de74848408bebe41d770dc49a50.tar.gz | |
repository: Change ownership semantics
The ownership semantics have been changed all over the library to be
consistent. There are no more "borrowed" or duplicated references.
Main changes:
- `git_repository_open2` and `3` have been dropped.
- Added setters and getters to hotswap all the repository owned
objects:
`git_repository_index`
`git_repository_set_index`
`git_repository_odb`
`git_repository_set_odb`
`git_repository_config`
`git_repository_set_config`
`git_repository_workdir`
`git_repository_set_workdir`
Now working directories/index files/ODBs and so on can be
hot-swapped after creating a repository and between operations.
- All these objects now have proper ownership semantics with
refcounting: they all require freeing after they are no longer
needed (the repository always keeps its internal reference).
- Repository open and initialization has been updated to keep in
mind the configuration files. Bare repositories are now always
detected, and a default config file is created on init.
- All the tests affected by these changes have been dropped from the
old test suite and ported to the new one.
Diffstat (limited to 'src/fetch.c')
| -rw-r--r-- | src/fetch.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/src/fetch.c b/src/fetch.c index a42732925..93f0980ca 100644 --- a/src/fetch.c +++ b/src/fetch.c @@ -24,7 +24,7 @@ static int filter_wants(git_remote *remote) git_headarray refs; git_remote_head *head; git_transport *t = remote->transport; - git_repository *repo = remote->repo; + git_odb *odb = NULL; const git_refspec *spec; int error; unsigned int i = 0; @@ -39,6 +39,10 @@ static int filter_wants(git_remote *remote) goto cleanup; } + error = git_repository_odb__weakptr(&odb, remote->repo); + if (error < GIT_SUCCESS) + goto cleanup; + /* * The fetch refspec can be NULL, and what this means is that the * user didn't specify one. This is fine, as it means that we're @@ -53,7 +57,7 @@ static int filter_wants(git_remote *remote) */ head = refs.heads[0]; if (refs.len > 0 && !strcmp(head->name, GIT_HEAD_FILE)) { - if (git_odb_exists(repo->db, &head->oid)) + if (git_odb_exists(odb, &head->oid)) head->local = 1; else remote->need_pack = 1; @@ -77,7 +81,7 @@ static int filter_wants(git_remote *remote) } /* If we have the object, mark it so we don't ask for it */ - if (git_odb_exists(repo->db, &head->oid)) + if (git_odb_exists(odb, &head->oid)) head->local = 1; else remote->need_pack = 1; |