diff options
| author | Vicent Martà <vicent@github.com> | 2013-11-01 04:22:12 -0700 |
|---|---|---|
| committer | Vicent Martà <vicent@github.com> | 2013-11-01 04:22:12 -0700 |
| commit | ab44c62e548373c1494e967f54720faa06ce38b7 (patch) | |
| tree | cd9dd4e90f790a99534f8024f8686a8d8672f117 /src/netops.c | |
| parent | f93f3790c511d3ed821bf63fdaf5aeec155e195b (diff) | |
| parent | 048f837b2fd5cd12ed7e3ca497f11460ab3114a9 (diff) | |
| download | libgit2-ab44c62e548373c1494e967f54720faa06ce38b7.tar.gz | |
Merge pull request #1928 from libgit2/parse-bad-urls
Improve bad URL handling
Diffstat (limited to 'src/netops.c')
| -rw-r--r-- | src/netops.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/netops.c b/src/netops.c index 7a61ef820..7e13f12e7 100644 --- a/src/netops.c +++ b/src/netops.c @@ -679,9 +679,10 @@ int gitno_extract_url_parts( slash = strchr(url, '/'); at = strchr(url, '@'); - if (slash == NULL) { - giterr_set(GITERR_NET, "Malformed URL: missing /"); - return -1; + if (!slash || + (colon && (slash < colon))) { + giterr_set(GITERR_NET, "Malformed URL"); + return GIT_EINVALIDSPEC; } start = url; |