Fix a bug in the git_oid_to_string() function

When git_oid_to_string() was passed a buffer size larger than
GIT_OID_HEXSZ+1, the function placed the c-string NUL char at
the wrong position. Fix the code to place the NUL at the end
of the (possibly truncated) oid string.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>

1 files changed, 3 insertions, 1 deletions

diff --git a/src/oid.c b/src/oid.c
index 182859f51..0bc152bdf 100644
--- a/src/oid.c
+++ b/src/oid.c
@@ -106,7 +106,9 @@ char *git_oid_to_string(char *out, size_t n, const git_oid *oid)
 
 	if (n > 0) {
 		git_oid_fmt(str, oid);
-		memcpy(out, str, n > GIT_OID_HEXSZ ? GIT_OID_HEXSZ : n);
+		if (n > GIT_OID_HEXSZ)
+			n = GIT_OID_HEXSZ;
+		memcpy(out, str, n);
 	}
 
 	out[n] = '\0';