summaryrefslogtreecommitdiff
path: root/src/refs.c
diff options
context:
space:
mode:
authorPatrick Steinhardt <ps@pks.im>2017-06-30 13:39:01 +0200
committerPatrick Steinhardt <ps@pks.im>2017-07-03 08:51:48 +0000
commit0c7f49dd4316b332f30b4ea72a657bace41e1245 (patch)
treece4e7b43e8dd32e9daf268cedca2414191f3e472 /src/refs.c
parent2480d0eba85781c802027073a91f6f4331d4f71b (diff)
downloadlibgit2-0c7f49dd4316b332f30b4ea72a657bace41e1245.tar.gz
Make sure to always include "common.h" first
Next to including several files, our "common.h" header also declares various macros which are then used throughout the project. As such, we have to make sure to always include this file first in all implementation files. Otherwise, we might encounter problems or even silent behavioural differences due to macros or defines not being defined as they should be. So in fact, our header and implementation files should make sure to always include "common.h" first. This commit does so by establishing a common include pattern. Header files inside of "src" will now always include "common.h" as its first other file, separated by a newline from all the other includes to make it stand out as special. There are two cases for the implementation files. If they do have a matching header file, they will always include this one first, leading to "common.h" being transitively included as first file. If they do not have a matching header file, they instead include "common.h" as first file themselves. This fixes the outlined problems and will become our standard practice for header and source files inside of the "src/" from now on.
Diffstat (limited to 'src/refs.c')
-rw-r--r--src/refs.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/refs.c b/src/refs.c
index f7120d9ee..942054001 100644
--- a/src/refs.c
+++ b/src/refs.c
@@ -6,6 +6,7 @@
*/
#include "refs.h"
+
#include "hash.h"
#include "repository.h"
#include "fileops.h"