summaryrefslogtreecommitdiff
path: root/src/signature.c
diff options
context:
space:
mode:
authorCarlos Martín Nieto <cmn@dwim.me>2014-06-04 17:31:42 +0200
committerCarlos Martín Nieto <cmn@dwim.me>2014-06-04 17:31:42 +0200
commit57cb1179e5c9c8f5c27c9115f13f1cae5d0f87a0 (patch)
tree67871086b1437dcd410979b423cd3ba140ab9257 /src/signature.c
parent90befde4a1938641dfdb9a7bdb9f361d1de5c26f (diff)
downloadlibgit2-cmn/config-default-snapshot.tar.gz
Make the default repository config getter return a snapshotcmn/config-default-snapshot
You should always use a snapshot, with the sole exception of writing to the configuration. Any reads that are not against a snapshot have race conditions, both in terms of returned values as well as dangling pointers.
Diffstat (limited to 'src/signature.c')
-rw-r--r--src/signature.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/signature.c b/src/signature.c
index 2545b7519..f501cd8b6 100644
--- a/src/signature.c
+++ b/src/signature.c
@@ -144,7 +144,7 @@ int git_signature_default(git_signature **out, git_repository *repo)
git_config *cfg;
const char *user_name, *user_email;
- if ((error = git_repository_config_snapshot(&cfg, repo)) < 0)
+ if ((error = git_repository_config(&cfg, repo)) < 0)
return error;
if (!(error = git_config_get_string(&user_name, cfg, "user.name")) &&