diff options
| author | Russell Belfer <rb@github.com> | 2013-10-08 12:45:43 -0700 |
|---|---|---|
| committer | Russell Belfer <rb@github.com> | 2013-10-08 12:45:43 -0700 |
| commit | 14997dc5f69e7ceebe502b32087d809a8482bf78 (patch) | |
| tree | ff245ed60887dc4eddd3b3ea65e7dd215deeeb62 /src/win32 | |
| parent | 5173ea921d4ccbbe7d61ddce9a0920c2e1c82035 (diff) | |
| download | libgit2-14997dc5f69e7ceebe502b32087d809a8482bf78.tar.gz | |
More filemode cleanups for FAT on MacOS
This cleans up some additional issues. The main change is that
on a filesystem that doesn't support mode bits, libgit2 will now
create new blobs with GIT_FILEMODE_BLOB always instead of being
at the mercy to the filesystem driver to report executable or not.
This means that if "core.filemode" lies and claims that filemode
is not supported, then we will ignore the executable bit from the
filesystem. Previously we would have allowed it.
This adds an option to the new git_repository_reset_filesystem to
recurse through submodules if desired. There may be other types
of APIs that would like a "recurse submodules" option, but this
one is particularly useful.
This also has a number of cleanups, etc., for related things
including trying to give better error messages when problems come
up from the filesystem. For example, the FAT filesystem driver on
MacOS appears to return errno EINVAL if you attempt to write a
filename with invalid UTF-8 in it. We try to capture that with a
better error message now.
Diffstat (limited to 'src/win32')
| -rw-r--r-- | src/win32/posix_w32.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/win32/posix_w32.c b/src/win32/posix_w32.c index 2f490529c..18f717b0f 100644 --- a/src/win32/posix_w32.c +++ b/src/win32/posix_w32.c @@ -125,8 +125,8 @@ static int do_lstat( errno = ENOENT; - /* We need POSIX behavior, then ENOTDIR must set when any of the folders in the - * file path is a regular file,otherwise ENOENT must be set. + /* To match POSIX behavior, set ENOTDIR when any of the folders in the + * file path is a regular file, otherwise set ENOENT. */ if (posix_enotdir) { /* scan up path until we find an existing item */ |