Clean up annoying warnings

The indexer code was generating warnings on Windows 64-bit.  I
looked closely at the logic and was able to simplify it a bit.

Also this fixes some other Windows and Linux warnings.

2 files changed, 4 insertions, 1 deletions

diff --git a/tests-clar/core/iconv.c b/tests-clar/core/iconv.c
index 5a3e1dee0..73bc99a23 100644
--- a/tests-clar/core/iconv.c
+++ b/tests-clar/core/iconv.c
@@ -21,6 +21,7 @@ void test_core_iconv__unchanged(void)
 	size_t datalen = strlen(data);
 
 	cl_git_pass(git_path_iconv(&ic, &data, &datalen));
+	GIT_UNUSED(datalen);
 
 	/* There are no high bits set, so this should leave data untouched */
 	cl_assert(data == original);
@@ -32,6 +33,7 @@ void test_core_iconv__decomposed_to_precomposed(void)
 	size_t datalen = strlen(nfd);
 
 	cl_git_pass(git_path_iconv(&ic, &data, &datalen));
+	GIT_UNUSED(datalen);
 
 	/* The decomposed nfd string should be transformed to the nfc form
 	 * (on platforms where iconv is enabled, of course).
@@ -49,6 +51,7 @@ void test_core_iconv__precomposed_is_unmodified(void)
 	size_t datalen = strlen(nfc);
 
 	cl_git_pass(git_path_iconv(&ic, &data, &datalen));
+	GIT_UNUSED(datalen);
 
 	/* data is already in precomposed form, so even though some bytes have
 	 * the high-bit set, the iconv transform should result in no change.
diff --git a/tests-clar/online/push.c b/tests-clar/online/push.c
index 4c2bec7ca..957cef7ca 100644
--- a/tests-clar/online/push.c
+++ b/tests-clar/online/push.c
@@ -356,7 +356,7 @@ static int push_pack_progress_cb(int stage, unsigned int current, unsigned int t
 static int push_transfer_progress_cb(unsigned int current, unsigned int total, size_t bytes, void* payload)
 {
 	int *was_called = (int *) payload;
-	GIT_UNUSED(current); GIT_UNUSED(total); GIT_UNUSED(bytes); 
+	GIT_UNUSED(current); GIT_UNUSED(total); GIT_UNUSED(bytes);
 	*was_called = 1;
 	return 0;
 }