I broke your bindings

Hey. Apologies in advance -- I broke your bindings.

This is a major commit that includes a long-overdue redesign of the
whole object-database structure. This is expected to be the last major
external API redesign of the library until the first non-alpha release.

Please get your bindings up to date with these changes. They will be
included in the next minor release. Sorry again!

Major features include:

	- Real caching and refcounting on parsed objects
	- Real caching and refcounting on objects read from the ODB
	- Streaming writes & reads from the ODB
	- Single-method writes for all object types
	- The external API is now partially thread-safe

The speed increases are significant in all aspects, specially when
reading an object several times from the ODB (revwalking) and when
writing big objects to the ODB.

Here's a full changelog for the external API:

blob.h
------

	- Remove `git_blob_new`
	- Remove `git_blob_set_rawcontent`
	- Remove `git_blob_set_rawcontent_fromfile`
	- Rename `git_blob_writefile` -> `git_blob_create_fromfile`
	- Change `git_blob_create_fromfile`:
		The `path` argument is now relative to the repository's working dir
	- Add `git_blob_create_frombuffer`

commit.h
--------

	- Remove `git_commit_new`
	- Remove `git_commit_add_parent`
	- Remove `git_commit_set_message`
	- Remove `git_commit_set_committer`
	- Remove `git_commit_set_author`
	- Remove `git_commit_set_tree`

	- Add `git_commit_create`
	- Add `git_commit_create_v`
	- Add `git_commit_create_o`
	- Add `git_commit_create_ov`

tag.h
-----

	- Remove `git_tag_new`
	- Remove `git_tag_set_target`
	- Remove `git_tag_set_name`
	- Remove `git_tag_set_tagger`
	- Remove `git_tag_set_message`

	- Add `git_tag_create`
	- Add `git_tag_create_o`

tree.h
------

	- Change `git_tree_entry_2object`:
		New signature is `(git_object **object_out, git_repository *repo, git_tree_entry *entry)`

	- Remove `git_tree_new`
	- Remove `git_tree_add_entry`
	- Remove `git_tree_remove_entry_byindex`
	- Remove `git_tree_remove_entry_byname`
	- Remove `git_tree_clearentries`
	- Remove `git_tree_entry_set_id`
	- Remove `git_tree_entry_set_name`
	- Remove `git_tree_entry_set_attributes`

object.h
------------

	- Remove `git_object_new
	- Remove `git_object_write`

	- Change `git_object_close`:
		This method is now *mandatory*. Not closing an object causes a
		memory leak.

odb.h
-----

	- Remove type `git_rawobj`
	- Remove `git_rawobj_close`
	- Rename `git_rawobj_hash` -> `git_odb_hash`
	- Change `git_odb_hash`:
		New signature is `(git_oid *id, const void *data, size_t len, git_otype type)`

	- Add type `git_odb_object`
	- Add `git_odb_object_close`

	- Change `git_odb_read`:
		New signature is `(git_odb_object **out, git_odb *db, const git_oid *id)`
	- Change `git_odb_read_header`:
		New signature is `(size_t *len_p, git_otype *type_p, git_odb *db, const git_oid *id)`
	- Remove `git_odb_write`
	- Add `git_odb_open_wstream`
	- Add `git_odb_open_rstream`

odb_backend.h
-------------

	- Change type `git_odb_backend`:
		New internal signatures are as follows

			int (* read)(void **, size_t *, git_otype *, struct git_odb_backend *, const git_oid *)
			int (* read_header)(size_t *, git_otype *, struct git_odb_backend *, const git_oid *)
			int (* writestream)(struct git_odb_stream **, struct git_odb_backend *, size_t, git_otype)
			int (* readstream)( struct git_odb_stream **, struct git_odb_backend *, const git_oid *)

	- Add type `git_odb_stream`
	- Add enum `git_odb_streammode`

Signed-off-by: Vicent Marti <tanoku@gmail.com>

1 files changed, 19 insertions, 56 deletions

diff --git a/tests/t04-commit.c b/tests/t04-commit.c
index 855cf9859..1140d3319 100644
--- a/tests/t04-commit.c
+++ b/tests/t04-commit.c
@@ -407,39 +407,42 @@ This is a commit created in memory and it will be written back to disk\n"
 
 static const char *tree_oid = "1810dff58d8a660512d4832e740f692884338ccd";
 
+
 BEGIN_TEST(write0, "write a new commit object from memory to disk")
 	git_repository *repo;
-	git_commit *commit, *parent;
-	git_tree *tree;
-	git_oid id;
+	git_commit *commit;
+	git_oid tree_id, parent_id, commit_id;
 	const git_signature *author, *committer;
 	/* char hex_oid[41]; */
 
 	must_pass(git_repository_open(&repo, REPOSITORY_FOLDER));
 
-	/* Create commit in memory */
-	must_pass(git_commit_new(&commit, repo));
-
-	/* Add new parent */
-	git_oid_mkstr(&id, commit_ids[4]);
-	must_pass(git_commit_lookup(&parent, repo, &id));
 
-	git_commit_add_parent(commit, parent);
+	git_oid_mkstr(&tree_id, tree_oid);
+	git_oid_mkstr(&parent_id, commit_ids[4]);
 
-	/* Set other attributes */
+	/* create signatures */
 	committer = git_signature_new(COMMITTER_NAME, COMMITTER_EMAIL, 123456789, 60);
 	must_be_true(committer != NULL);
 
 	author = git_signature_new(COMMITTER_NAME, COMMITTER_EMAIL, 987654321, 90);
 	must_be_true(author != NULL);
 
-	git_commit_set_committer(commit, committer);
-	git_commit_set_author(commit, author);
-	git_commit_set_message(commit, COMMIT_MESSAGE);
+	must_pass(git_commit_create_v(
+		&commit_id, /* out id */
+		repo,
+		NULL, /* do not update the HEAD */
+		author,
+		committer,
+		COMMIT_MESSAGE,
+		&tree_id,
+		1, &parent_id));
 
 	git_signature_free((git_signature *)committer);
 	git_signature_free((git_signature *)author);
 
+	must_pass(git_commit_lookup(&commit, repo, &commit_id));
+
 	/* Check attributes were set correctly */
 	author = git_commit_author(commit);
 	must_be_true(author != NULL);
@@ -457,47 +460,6 @@ BEGIN_TEST(write0, "write a new commit object from memory to disk")
 
 	must_be_true(strcmp(git_commit_message(commit), COMMIT_MESSAGE) == 0);
 
-	/* add new tree */
-	git_oid_mkstr(&id, tree_oid);
-	must_pass(git_tree_lookup(&tree, repo, &id));
-
-	git_commit_set_tree(commit, tree);
-
-	/* Test it has no OID */
-	must_be_true(git_commit_id(commit) == NULL);
-
-	/* Write to disk */
-	must_pass(git_object_write((git_object *)commit));
-
-	must_pass(remove_loose_object(REPOSITORY_FOLDER, (git_object *)commit));
-
-	git_repository_free(repo);
-END_TEST
-
-BEGIN_TEST(write1, "load a commit object, modify it and write it back")
-	git_repository *repo;
-	git_oid id;
-	git_commit *commit, *parent;
-	const char *message;
-	/* char hex_oid[41]; */
-
-	must_pass(git_repository_open(&repo, REPOSITORY_FOLDER));
-
-	git_oid_mkstr(&id, commit_ids[0]);
-
-	must_pass(git_commit_lookup(&commit, repo, &id));
-
-	message = git_commit_message(commit);
-
-	git_commit_set_message(commit, "This is a new test message. Cool!\n");
-
-	git_oid_mkstr(&id, commit_ids[4]);
-	must_pass(git_commit_lookup(&parent, repo, &id));
-
-	git_commit_add_parent(commit, parent);
-
-	must_pass(git_object_write((git_object *)commit));
-
 	must_pass(remove_loose_object(REPOSITORY_FOLDER, (git_object *)commit));
 
 	git_repository_free(repo);
@@ -509,6 +471,7 @@ BEGIN_SUITE(commit)
 	ADD_TEST(parse1);
 	ADD_TEST(parse2);
 	ADD_TEST(details0);
+
 	ADD_TEST(write0);
-	ADD_TEST(write1);
+	//ADD_TEST(write1);
 END_SUITE