| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Fallback describes the mechanism, while unspecified explains what the
user is thinking.
|
|\
| |
| | |
Remove run-time configuration settings from submodules
|
| |
| |
| |
| |
| | |
These are not useful anymore, as we don't affect the instance's
configuration.
|
| |
| |
| |
| |
| |
| | |
In addition to mapping enums to strings in the configuration, we need to
know to delete the configuration option when given the "none" or "no"
option.
|
| |
| |
| |
| |
| |
| | |
We currently do not handle those enum values which require us to set
"true" or unset variables in all cases. Use a common function which does
understand this by looking at our mapping directly.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
The current code will always fail, but only because it's asking for a
string on a live config. Take a snapshot and make sure we fail with
ENOTFOUND instead of any old error.
|
| | |
|
| |
| |
| |
| |
| | |
We no longer have any setters which affect an instance, so
`git_submodule_save()` is no longer relevant.
|
| |
| |
| |
| | |
With this one, we can get rid of the edit_and_save test.
|
| | |
|
| |
| |
| |
| |
| |
| | |
Similarly to the other ones. In this test we copy over testing
`RECURSE_YES` which shows an error in our handling of the `YES` variant
which we may have to port to the rest.
|
| |
| |
| |
| |
| | |
Moving on with the removal of runtime-changing variables, the update
setting for a remote is whatever it was when it was looked up.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
During the cache deletion, the check for whether we consider a submodule
to exist got changed regarding submodules which are in the worktree but
not configured.
Instead of checking for the url field to be populated, check the
location where we've found it.
|
| |
| |
| |
| |
| | |
During the removal of the cache, we also removed the ability to use
`_lookup()` to search by path rather than name. Bring this logic back.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This lets us specify in the status call which ignore rules we want to
use (optionally falling back to whatever the submodule has in its
configuration).
This removes one of the reasons for having `_set_ignore()` set the value
in-memory. We re-use the `IGNORE_RESET` value for this as it is no
longer relevant but has a similar purpose to `IGNORE_FALLBACK`.
Similarly, we remove `IGNORE_DEFAULT` which does not have use outside of
initializers and move that to fall back to the configuration as well.
|
| |
| |
| |
| |
| |
| | |
As submodules are becomes more like values, we should not let a status
check to update its properties. Instead of taking a submodule, have
status take a repo and submodule name.
|
| |
| |
| |
| |
| | |
Instead of affecting a particular instance, make it change the
configuration.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Having this cache and giving them out goes against our multithreading
guarantees and it makes it impossible to use submodules in a
multi-threaded environment, as any thread can ask for a refresh which
may reallocate some string in the submodule struct which we've accessed
in a different one via a getter.
This makes the submodules behave more like remotes, where each object is
created upon request and not shared except explicitly by the user. This
means that some tests won't pass yet, as they assume they can affect the
submodule objects in the cache and that will affect later operations.
|
|\ \
| | |
| | | |
Implement a cURL stream
|
| | |
| | |
| | |
| | |
| | |
| | | |
If the libcurl stream is available, use that as the underlying stream
instead of the socket stream. This allows us to set a proxy for HTTPS
connections.
|
| | |
| | |
| | |
| | |
| | | |
We do not want libcurl to perform the TLS negotiation for us, so we
don't need to pass this option.
|
| | |
| | |
| | |
| | |
| | |
| | | |
The TLS streams talk over the curl stream themselves, so we don't need
to ask for it explicitly. Do so in the case of the non-encrypted one so
we can still make use proxies in that case.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When linking against libcurl, use it as the underlying transport instead
of straight sockets. We can't quite just give over the file descriptor,
as curl puts it into non-blocking mode, so we build a custom BIO so
OpenSSL sends the data through our stream, be it the socket or curl
streams.
|
| | |
| | |
| | |
| | |
| | |
| | | |
The information is exposed by curl for some crypto libraries in the form
of name:content strings. We can't do much more than return this
information.
|
| | |
| | |
| | |
| | |
| | | |
Of the built-in ones, only cURL support it, but there's no reason a
user-provided stream wouldn't support it.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If the stream claims to support this feature, we can let the transport
set the proxy.
We also set HTTPPROXYTUNNEL option so curl can create a tunnel through
the proxy which lets us create our own TLS session (if needed).
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
cURL has a mode in which it acts a lot like our streams, providing send
and recv functions and taking care of the TLS and proxy setup for us.
Implement a new stream which uses libcurl instead of raw sockets or the
TLS libraries directly. This version does not support reporting
certificates or proxies yet.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Handle binary DIFFABLEness properly
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Always set `GIT_DIFF_PATCH_DIFFABLE` for all files, regardless of
binary-ness, so that the binary callback is invoked to either
show the binary contents, or just print the standard "Binary files
differ" message. We may need to do deeper inspection for binary
files where we have avoided loading the contents into a file map.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Ensure that even when we're forcing a binary diff that we do not
assume that there *is* a diff. There should be an empty diff for
no change.
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We test the generation of the textual patch via the patch function,
which are just one of two possibilities to get the output.
Add a second patch generation via the diff function to make sure both
outputs are in sync.
|
|\ \ \
| |/ /
|/| | |
Stash workdir correctly when added in the index, modified in the workdir
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When stashing the workdir tree, examine the index as well. Using
a mechanism similar to `git_diff_tree_to_workdir_with_index`
allows us to determine that a file was added in the index and
subsequently modified in the working directory. Without examining
the index, we would erroneously believe that this file was
untracked and fail to include it in the working directory tree.
Use a slightly modified `git_diff_tree_to_workdir_with_index` in
order to avoid some of the behavior custom to `git diff`. In
particular, be sure to include the working directory side of a
file when it was deleted in the index.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Ensure that when a file is added in the index and subsequently
modified in the working directory, the stashed working directory
tree contains the actual working directory contents.
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
Drop `git_diff__merge_like_cgit_reversed`, since it's a copy and
paste mess of slightly incompatible changes.
|
|\ \ \
| | | |
| | | | |
Fixes
|
| | | | |
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Fixed GIT_DELTA_CONFLICTED not returned in some cases
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If an index entry for a file that is not in HEAD is in conflicted state,
when diffing HEAD with the index, the status field of the corresponding git_diff_delta was incorrectly reported as GIT_DELTA_ADDED instead of GIT_DELTA_CONFLICTED.
This was due to handle_unmatched_new_item() initially setting the status
to GIT_DELTA_CONFLICTED but then overriding it later with GIT_DELTA_ADDED.
|
|\ \ \
| | | |
| | | | |
Add `const` qualifier
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This fixes a warning in `examples/describe.c` without breaking the main build.
OTOH, I'm not sure if this is an API-compatible change.
|
|\ \ \ \
| | | | |
| | | | | |
racy-git, the missing link
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Even though the file is empty and thus the size in the entry matches, we
should be able to detect it as a difference.
|