summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* CMake: activate the rpath policy for OSXcmn/rpath-policyCarlos Martín Nieto2015-12-101-0/+1
| | | | | This activates the newer policy of using rpath in the build and shuts CMake up about it when we're building.
* Merge pull request #3542 from libgit2/cmn/reset-dir-fileCarlos Martín Nieto2015-12-092-6/+58
|\ | | | | reset: perform the checkout before moving HEAD or the index
| * reset: perform the checkout before moving HEAD or the indexcmn/reset-dir-fileCarlos Martín Nieto2015-12-092-6/+58
|/ | | | | | This keeps the state of the workdir the same as one from HEAD, removing a source of possible confusion when calculating the work that is to be done.
* CHANGELOG: add some things we missedCarlos Martín Nieto2015-12-091-1/+11
|
* Merge pull request #3539 from libgit2/typedef-submodule-cbCarlos Martín Nieto2015-12-082-2/+13
|\ | | | | Use a typedef for the submodule_foreach callback.
| * Play nice with the docs.typedef-submodule-cbjoshaber2015-12-081-5/+4
| |
| * Use a typedef for the submodule_foreach callback.joshaber2015-12-082-2/+14
| | | | | | | | | | | | This fits with the style for the rest of the project, but more importantly, makes life easier for bindings authors who auto-generate code.
* | Merge pull request #3537 from libgit2/cmn/tree-is-sortedEdward Thomson2015-12-082-1/+6
|\ \ | |/ |/| tree: mark a tree as already sorted
| * tree: mark a tree as already sortedcmn/tree-is-sortedCarlos Martín Nieto2015-12-062-1/+6
| | | | | | | | | | The trees are sorted on-disk, so we don't have to go over them again. This cuts almost a fifth of time spent parsing trees.
* | Merge pull request #3526 from sschuberth/cmake-number-compareCarlos Martín Nieto2015-12-061-1/+1
|\ \ | | | | | | CMakeLists: Compare CMAKE_SIZEOF_VOID_P as a number, not as a string
| * | CMakeLists: Compare CMAKE_SIZEOF_VOID_P as a number, not as a stringSebastian Schuberth2015-12-021-1/+1
| | |
* | | Merge pull request #3529 from mgorny/fix-checkout-test-umaskCarlos Martín Nieto2015-12-061-1/+1
|\ \ \ | |_|/ |/| | checkout test: Apply umask to file-mode test as well
| * | checkout test: Apply umask to file-mode test as wellMichał Górny2015-12-011-1/+1
| |/ | | | | | | | | | | | | | | Fix the file-mode test to expect system umask being applied to the created file as well (it is currently applied to the directory only). This fixes the test on systems where umask != 022. Signed-off-by: Michał Górny <mgorny@gentoo.org>
* | Merge pull request #3530 from libgit2/cmn/parse-modeEdward Thomson2015-12-031-5/+21
|\ \ | | | | | | tree: use a specialised mode parse function
| * | tree: use a specialised mode parse functioncmn/parse-modeCarlos Martín Nieto2015-12-021-5/+21
| |/ | | | | | | | | Instead of going out to strtol, which is made to parse generic numbers, copy a parse function from git which is specialised for file modes.
* | Merge pull request #3534 from ethomson/index_canonicalize_fixCarlos Martín Nieto2015-12-031-1/+1
|\ \ | |/ |/| index: canonicalize inserted paths safely
| * index: canonicalize inserted paths safelyEdward Thomson2015-12-031-1/+1
|/ | | | | | | | | | | | | | | | | | When adding to the index, we look to see if a portion of the given path matches a portion of a path in the index. If so, we will use the existing path information. For example, when adding `foo/bar.c`, if there is an index entry to `FOO/other` and the filesystem is case insensitive, then we will put `bar.c` into the existing tree instead of creating a new one with a different case. Use `strncmp` to do that instead of `memcmp`. When we `bsearch` into the index, we locate the position where the new entry would go. The index entry at that position does not necessarily have a relation to the entry we're adding, so we cannot make assumptions and use `memcmp`. Instead, compare them as strings. When canonicalizing paths, we look for the first index entry that matches a given substring.
* Merge pull request #3527 from pks-t/pks/tree-entry-memleakEdward Thomson2015-12-011-0/+2
|\ | | | | tree: mark cloned tree entries as un-pooled
| * tree: mark cloned tree entries as un-pooledPatrick Steinhardt2015-12-011-0/+2
|/ | | | | | | | | | | | When duplicating a `struct git_tree_entry` with `git_tree_entry_dup` the resulting structure is not allocated inside a memory pool. As we do a 1:1 copy of the original struct, though, we also copy the `pooled` field, which is set to `true` for pooled entries. This results in a huge memory leak as we never free tree entries that were duplicated from a pooled tree entry. Fix this by marking the newly duplicated entry as un-pooled.
* Merge pull request #3508 from libgit2/cmn/tree-parse-speedEdward Thomson2015-11-302-17/+55
|\ | | | | Improvements to tree parsing speed
| * tree: ensure the entry filename fits in 16 bitscmn/tree-parse-speedCarlos Martín Nieto2015-11-301-16/+26
| | | | | | | | | | | | Return an error in case the length is too big. Also take this opportunity to have a single allocating function for the size and overflow logic.
| * tree: make path len uint16_t and avoid holesCarlos Martín Nieto2015-11-282-2/+2
| | | | | | | | | | | | This reduces the size of the struct from 32 to 26 bytes, and leaves a single padding byte at the end of the struct (which comes from the zero-length array).
| * tree: calculate the filename length onceCarlos Martín Nieto2015-11-281-5/+8
| | | | | | | | | | We already know the size due to the `memchr()` so use that information instead of calling `strlen()` on it.
| * tree: pool the entry memory allocationsCarlos Martín Nieto2015-11-282-6/+33
| | | | | | | | | | | | | | These are rather small allocations, so we end up spending a non-trivial amount of time asking the OS for memory. Since these entries are tied to the lifetime of their tree, we can give the tree a pool so we speed up the allocations.
| * tree: avoid advancing over the filename multiple timesCarlos Martín Nieto2015-11-281-4/+2
| | | | | | | | | | | | | | We've already looked at the filename with `memchr()` and then used `strlen()` to allocate the entry. We already know how much we have to advance to get to the object id, so add the filename length instead of looking at each byte again.
* | Merge pull request #3525 from pks-t/pks/fix-nested-struct-warningCarlos Martín Nieto2015-11-302-3/+1
|\ \ | | | | | | Compiler warning fixes
| * | object: remove unused constant OBJECT_BASE_SIZEPatrick Steinhardt2015-11-301-2/+0
| | |
| * | tests: fix warning for nested struct initializationPatrick Steinhardt2015-11-301-1/+1
|/ /
* | Merge pull request #3513 from ethomson/merge_recursiveCarlos Martín Nieto2015-11-30175-192/+1237
|\ \ | |/ |/| Recursive Merge
| * recursive merge: add a recursion limitEdward Thomson2015-11-253-3/+49
| |
| * merge: handle conflicts in recursive base buildingEdward Thomson2015-11-2528-20/+201
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When building a recursive merge base, allow conflicts to occur. Use the file (with conflict markers) as the common ancestor. The user has already seen and dealt with this conflict by virtue of having a criss-cross merge. If they resolved this conflict identically in both branches, then there will be no conflict in the result. This is the best case scenario. If they did not resolve the conflict identically in the two branches, then we will generate a new conflict. If the user is simply using standard conflict output then the results will be fairly sensible. But if the user is using a mergetool or using diff3 output, then the common ancestor will be a conflict file (itself with diff3 output, haha!). This is quite terrible, but it matches git's behavior.
| * merge tests: add complex recursive exampleEdward Thomson2015-11-2512-6/+39
| |
| * recursive: test conflict output during recursive mergeEdward Thomson2015-11-252-0/+81
| |
| * merge tests: move expected data into own fileEdward Thomson2015-11-256-44/+47
| |
| * merge: use annotated commits for recursionEdward Thomson2015-11-253-68/+122
| | | | | | | | | | | | | | Use annotated commits to act as our virtual bases, instead of regular commits, to avoid polluting the odb with virtual base commits and trees. Instead, build an annotated commit with an index and pointers to the commits that it was merged from.
| * merge: merge annotated commits instead of regular commitsEdward Thomson2015-11-253-166/+159
| |
| * merge: octopus merge common ancestors when >2Edward Thomson2015-11-253-119/+189
| | | | | | | | | | | | When there are more than two common ancestors, continue merging the virtual base with the additional common ancestors, effectively octopus merging a new virtual base.
| * merge: add recursive test with conflicting contentsEdward Thomson2015-11-259-0/+32
| |
| * merge: compute octopus merge basesEdward Thomson2015-11-251-89/+100
| |
| * merge: add recursive test with three merge basesEdward Thomson2015-11-2528-0/+65
| |
| * merge: improve test names in recursive merge testsEdward Thomson2015-11-251-8/+8
| |
| * merge: add a third-level recursive mergeEdward Thomson2015-11-2513-0/+58
| |
| * merge: add a second-level recursive mergeEdward Thomson2015-11-2512-2/+57
| |
| * merge: build virtual base of multiple merge basesEdward Thomson2015-11-251-10/+123
| | | | | | | | | | When the commits to merge have multiple common ancestors, build a "virtual" base tree by merging the common ancestors.
| * merge: add simple recursive testEdward Thomson2015-11-2571-5/+245
| | | | | | | | | | Add a simple recursive test - where multiple ancestors exist and creating a virtual merge base from them would prevent a conflict.
| * merge: rename `git_merge_tree_flags_t` -> `git_merge_flags_t`Edward Thomson2015-11-259-34/+44
| |
* | Merge pull request #3523 from pks-t/memleak-fixesEdward Thomson2015-11-243-1/+6
|\ \ | | | | | | Memleak fixes
| * | tests: win32::longpath: free expected_msgPatrick Steinhardt2015-11-241-0/+2
| | |
| * | tests: config::stress: free `git_config` structsPatrick Steinhardt2015-11-241-0/+3
| | |
| * | tests: config::global: fix memleak in open_programdataPatrick Steinhardt2015-11-241-1/+1
| | |