summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | diff_generate: validate oid file sizeEdward Thomson2019-01-251-2/+2
| | | | | | | | | | | | Index entries are 32 bit unsigned ints, not `size_t`s.
| * | describe: don't mix and match abbreviated size typesEdward Thomson2019-01-251-2/+2
| | | | | | | | | | | | | | | The git_describe_format_options.abbreviated_size type is an unsigned int. There's no need for it to be anything else; keep it what it is.
| * | delta: validate sizes and cast safelyEdward Thomson2019-01-251-4/+11
| | | | | | | | | | | | | | | Quiet down a warning from MSVC about how we're potentially losing data. Validate that our data will fit into the type provided then cast.
| * | git transport: only write INT_MAX bytesEdward Thomson2019-01-251-5/+9
| | | | | | | | | | | | | | | The transport code returns an `int` with the number of bytes written; thus only attempt to write at most `INT_MAX`.
| * | windows: add SSIZE_MAXEdward Thomson2019-01-251-0/+6
| | | | | | | | | | | | | | | | | | Windows doesn't include ssize_t or its _MAX value by default. We are already declaring ssize_t as SSIZE_T, which is __int64_t on Win64 and long otherwise. Include its _MAX value as a correspondence to its type.
| * | streams: don't write more than SSIZE_MAXEdward Thomson2019-01-254-13/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | Our streams implementation takes a `size_t` that indicates the length of the data buffer to be written, and returns an `ssize_t` that indicates the length that _was_ written. Clearly no such implementation can write more than `SSIZE_MAX` bytes. Ensure that each TLS stream implementation does not try to write more than `SSIZE_MAX` bytes (or smaller; if the given implementation takes a smaller size).
| * | buffer: explicitly castEdward Thomson2019-01-251-1/+1
| | | | | | | | | | | | | | | Quiet down a warning from MSVC about how we're potentially losing data. This is safe since we've explicitly tested it.
| * | blame: make hunk_cmp handle unsigned differencesEdward Thomson2019-01-251-1/+6
| | |
| * | apply: make update_hunk accept a size_tEdward Thomson2019-01-251-1/+1
| | |
| * | MSVC: ignore empty compilation units (warning LNK4221)Edward Thomson2019-01-251-0/+3
| | | | | | | | | | | | | | | | | | | | | A number of source files have their implementation #ifdef'd out (because they target another platform). MSVC warns on empty compilation units (with warning LNK4221). Ignore warning 4221 when creating the object library.
| * | test: cast to a char the zstream testEdward Thomson2019-01-251-1/+1
| | |
| * | index test: cast times explicitlyEdward Thomson2019-01-251-2/+2
| | | | | | | | | | | | Cast actual filesystem data to the int32_t that index entries store.
| * | iterator: cast filesystem iterator entry values explicitlyEdward Thomson2019-01-251-3/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The filesystem iterator takes `stat` data from disk and puts them into index entries, which use 32 bit ints for time (the seconds portion) and filesize. However, on most systems these are not 32 bit, thus will typically invoke a warning. Most users ignore these fields entirely. Diff and checkout code do use the values, however only for the cache to determine if they should check file modification. Thus, this is not a critical error (and will cause a hash recomputation at worst).
| * | blob: validate that blob sizes fit in a size_tEdward Thomson2019-01-258-20/+52
| | | | | | | | | | | | | | | | | | Our blob size is a `git_off_t`, which is a signed 64 bit int. This may be erroneously negative or larger than `SIZE_MAX`. Ensure that the blob size fits into a `size_t` before casting.
| * | tree: cast filename length in git_tree__parse_rawEdward Thomson2019-01-251-2/+2
| | | | | | | | | | | | | | | Quiet down a warning from MSVC about how we're potentially losing data. Ensure that we're within a uint16_t before we do.
| * | odb_loose: explicitly cast to size_tEdward Thomson2019-01-251-1/+1
| | | | | | | | | | | | | | | | | | Quiet down a warning from MSVC about how we're potentially losing data. This is safe since we've explicitly tested that it's positive and less than SIZE_MAX.
| * | patch: explicitly cast down in parse_header_percentEdward Thomson2019-01-251-1/+1
| | | | | | | | | | | | | | | | | | Quiet down a warning from MSVC about how we're potentially losing data. This is safe since we've explicitly tested that it's within the range of 0-100.
| * | index: explicitly cast down to a size_tEdward Thomson2019-01-251-1/+1
| | | | | | | | | | | | | | | | | | Quiet down a warning from MSVC about how we're potentially losing data. This cast is safe since we've explicitly tested that `strip_len` <= `last_len`.
| * | diff: explicitly cast in flush_hunkEdward Thomson2019-01-251-1/+1
| |/ | | | | | | Quiet down a warning from MSVC about how we're potentially losing data.
* | Merge pull request #4869 from libgit2/ethomson/ci_nightlyEdward Thomson2019-01-261-4/+4
|\ \ | |/ |/| Nightlies: use `latest` docker images
| * nightly: use latest images, not test imagesEdward Thomson2019-01-261-4/+4
|/
* Merge pull request #4858 from tiennou/fix/index-ext-readEdward Thomson2019-01-2510-14/+54
|\ | | | | index: preserve extension parsing errors
| * index: preserve extension parsing errorsEtienne Samson2019-01-2410-14/+54
| | | | | | | | | | | | | | Previously, we would clobber any extension-specific error message with an "extension is truncated" message. This makes `read_extension` correctly preserve those errors, takes responsibility for truncation errors, and adds a new message with the actual extension signature for unsupported mandatory extensions.
* | Merge pull request #4952 from libgit2/ethomson/deprecationEdward Thomson2019-01-2515-263/+354
|\ \ | | | | | | Deprecate functions and constants more gently
| * | deprecation: define GIT_DEPRECATE_HARD internallyEdward Thomson2019-01-252-1/+5
| | | | | | | | | | | | | | | Ensure that we do not use any deprecated functions in the library source, test code or examples.
| * | deprecation: offer GIT_DEPRECATE_HARDEdward Thomson2019-01-251-0/+7
| | | | | | | | | | | | | | | Users can define `GIT_DEPRECATE_HARD` if they want to remove all functions that we've "softly" deprecated.
| * | deprecation: move deprecated tests into their own fileEdward Thomson2019-01-252-36/+60
| | | | | | | | | | | | | | | | | | Move the deprecated stream tests into their own compilation unit. This will allow us to disable any preprocessor directives that apply to deprecation just for these tests (eg, disabling `GIT_DEPRECATED_HARD`).
| * | deprecation: don't use deprecated stream cbEdward Thomson2019-01-251-1/+3
| | | | | | | | | | | | | | | | | | Avoid the deprecated `git_stream_cb` typedef since we want to compile the library without deprecated functions or types. Instead, we can unroll the alias to its actual type.
| * | deprecation: provide docurium deprecation noteEdward Thomson2019-01-251-0/+5
| | | | | | | | | | | | | | | Add `@deprecated` to the functions that are, so that they'll appear that way in docurium.
| * | deprecation: deprecated stream registration in if guardEdward Thomson2019-01-251-6/+15
| | | | | | | | | | | | | | | | | | | | | | | | `git_stream_register_tls` is now deprecated; mark it in an if guard with the deprecation. This should not be included in `deprecated.h` since it is an uncommonly used `sys` header file.
| * | deprecation: update changelog to reflect new policiesEdward Thomson2019-01-251-6/+14
| | |
| * | deprecation: move deprecated bits to deprecated.hEdward Thomson2019-01-257-210/+242
| | |
| * | fuzzers: don't use deprecated typesEdward Thomson2019-01-251-1/+1
| | |
| * | examples: don't use deprecated typesEdward Thomson2019-01-251-2/+2
|/ /
* | Merge pull request #4957 from csware/deprecatedEdward Thomson2019-01-252-3/+3
|\ \ | | | | | | Don't use deprecated constants
| * | Don't use deprecated constantsSven Strickroth2019-01-242-3/+3
|/ / | | | | | | | | | | Follow up for PR #4917. Signed-off-by: Sven Strickroth <email@cs-ware.de>
* | Merge pull request #4955 from csware/c4098Patrick Steinhardt2019-01-241-1/+1
|\ \ | |/ |/| Fix VS warning C4098: 'giterr_set_str' : void function returning a value
| * Fix VS warning C4098: 'giterr_set_str' : void function returning a valueSven Strickroth2019-01-241-1/+1
|/ | | | Signed-off-by: Sven Strickroth <email@cs-ware.de>
* Merge pull request #4917 from libgit2/ethomson/giterrEdward Thomson2019-01-22204-2040/+2150
|\ | | | | Move `giterr` to `git_error`
| * errors: update docs for giterr changesethomson/giterrEdward Thomson2019-01-223-19/+19
| |
| * errors: update static analysis tools for giterrEdward Thomson2019-01-222-5/+5
| | | | | | | | | | Update GITERR and giterr usages in the static code analysis tools to use the new names.
| * errors: remove giterr usage in examplesEdward Thomson2019-01-226-12/+12
| |
| * errors: remove giterr usage in fuzzersEdward Thomson2019-01-222-2/+2
| |
| * git_error: use new names in internal APIs and usageEdward Thomson2019-01-22184-1944/+1944
| | | | | | | | | | Move to the `git_error` name in the internal API for error-related functions.
| * git_error: deprecate error valuesEdward Thomson2019-01-222-35/+35
| | | | | | | | | | Replace the `GITERR` values with a `const int` to deprecate error values.
| * git_error: use full class name in public error APIEdward Thomson2019-01-228-58/+168
|/ | | | | | | | | Move to the `git_error` name in error-related functions, deprecating the `giterr` functions. This means, for example, that `giterr_last` is now `git_error_last`. The old names are retained for compatibility. This only updates the public API; internal API and function usage remains unchanged.
* Merge pull request #4949 from zlikavac32/fix-odb-foreach-cb-positive-error-codeEdward Thomson2019-01-203-2/+17
|\ | | | | odb: Fix odb foreach to also close on positive error code
| * Fix odb foreach to also close on positive error codeMarijan Šuflaj2019-01-203-2/+17
|/ | | | | | | | In include/git2/odb.h it states that callback can also return positive value which should break looping. Implementations of git_odb_foreach() and pack_backend__foreach() did not respect that.
* Merge pull request #4948 from libgit2/ethomson/memleaksEdward Thomson2019-01-201-5/+8
|\ | | | | repository: free memory in symlink detection function
| * repository: free memory in symlink detection functionethomson/memleaksEdward Thomson2019-01-201-5/+8
| |
View Lorry Controller Status