summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* cmake: don't create an object library for libgit2ethomson/cmake6Edward Thomson2021-11-161-24/+18
| | | | | | | | | | Now that we require cmake 3.15.0 or better, we can use the `$<TARGET_OBJECTS:...>` generator for any type of library, not just object libraries. This means we do not need to create an unnecessary abstraction in an object library. Removing this unnecessary target greatly simplifies the DX for IDE users.
* cmake: require 3.15.0 or betterEdward Thomson2021-11-161-1/+1
| | | | | Upgrade our cmake requirements so that we can adopt bigger, better features.
* ci: upgrade xenial to cmake 3.15.5Edward Thomson2021-11-161-2/+11
|
* Merge pull request #6114 from libgit2/ethomson/cmake5Edward Thomson2021-11-1430-866/+747
|\ | | | | cmake: further refactorings
| * cmake: move sha1 source selection into CMakeLists.txtEdward Thomson2021-11-142-12/+17
| | | | | | | | | | The select hashes module selects the hash; the CMakeLists.txt selects the files to implement it.
| * cmake: use a string not a boolean for LIBGIT2_FILENAMEEdward Thomson2021-11-141-1/+1
| |
| * cmake: refactor global variablesEdward Thomson2021-11-1412-59/+58
| | | | | | | | | | Update the global variables `LIBGIT2_OBJECTS` to `LIBGIT2_DEPENDENCY_OBJECTS` for clarity and consistency.
| * cmake: reformat modulesEdward Thomson2021-11-1420-812/+689
|/ | | | Apply the standard project cmake formatting to the modules.
* Merge pull request #6116 from ↵Edward Thomson2021-11-141-1/+1
|\ | | | | | | lhchavez/drop-volatile-qualifier-in-atomic-exchange
| * Fix a gcc 11 warning in src/thread.hlhchavez2021-11-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When building under gcc 11, there is a warning about an incompatible pointer type, since [`__atomic_exchange`](https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html) does not take `volatile` pointers: ``` In file included from ../src/common.h:81, from ../src/transports/winhttp.c:8: ../src/thread-utils.h: In function ‘git___swap’: ../src/thread-utils.h:168:9: warning: argument 3 of ‘__atomic_exchange’ discards ‘volatile’ qualifier [-Wincompatible-pointer-types] 168 | __atomic_exchange(ptr, &newval, &foundval, __ATOMIC_SEQ_CST); | ^~~~~~~~~~~~~~~~~ ``` This change drops the `volatile` qualifier so that the pointer type matches what `__atomic_exchange` expects.
* | Merge pull request #6115 from lhchavez/fix-indentation-threadstateEdward Thomson2021-11-141-2/+2
|\ \ | |/ |/|
| * Fix a gcc 11 warning in src/threadstate.clhchavez2021-11-141-2/+2
|/ | | | | | | | | | | | | | | | | | | | When building under gcc 11, there is a warning about a misaligned guard clause because there were mixed spaces and tabs: ``` [128/634] Building C object src/CMakeFiles/git2internal.dir/threadstate.c.o ../src/threadstate.c: In function ‘threadstate_dispose’: ../src/threadstate.c:39:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 39 | if (threadstate->error_t.message != git_str__initstr) | ^~ ../src/threadstate.c:41:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ 41 | threadstate->error_t.message = NULL; | ^~~~~~~~~~~ ../src/threadstate.c: At top level: ``` This change indents the code with tabs for consistency with the rest of the code, which makes the warning go away.
* Merge pull request #6113 from libgit2/ethomson/cmake3Edward Thomson2021-11-1156-111/+570
|\ | | | | Add missing-declarations warning globally
| * cmake: move missing-declarations warning to top-levelEdward Thomson2021-11-112-2/+1
| | | | | | | | | | We should enforce declarations throughout the code-base, including examples, fuzzers and tests, not just in the `src` tree.
| * tests: include function declarationsEdward Thomson2021-11-115-4/+13
| |
| * test: correct test namesEdward Thomson2021-11-113-3/+3
| |
| * tests: declare functions statically where appropriateEdward Thomson2021-11-1134-60/+442
| |
| * clar: declare summary functions as staticEdward Thomson2021-11-111-5/+5
| |
| * example: declare print_usage functionEdward Thomson2021-11-111-1/+1
| |
| * examples: remove unused functionEdward Thomson2021-11-111-15/+0
| |
| * fuzzers: declare static functions as staticEdward Thomson2021-11-112-4/+4
| |
| * fuzzers: declare standalone functionsEdward Thomson2021-11-119-2/+29
| |
| * tests: declare trace handler as staticEdward Thomson2021-11-111-1/+1
| |
| * tests: include test declarations for old gccEdward Thomson2021-11-111-1/+9
| | | | | | | | | | | | | | Older versions of gcc do not believe that we've adequately declared our test functions. Include `clar_suite.h` conditionally for those old versions. Do not do this on newer compilers to avoid unnecessary recompilation of the entire suite when we add or remove a test function.
| * clar: emit `clar_suite.h` with test declarationsEdward Thomson2021-11-111-13/+62
|/ | | | | | | We may want to have test function declarations; produce a header file with (only) the test declarations. Update clar to avoid overwriting the file unnecessarily to avoid bumping timestamps and potentially recompiling unnecessarily.
* Merge pull request #6112 from libgit2/ethomson/cmake3Edward Thomson2021-11-1120-428/+422
|\ | | | | cmake refactorings
| * cmake: refactor zlib selectionethomson/cmake3Edward Thomson2021-11-112-33/+35
| | | | | | | | Move zlib selection into its own cmake module.
| * cmake: refactor WinHTTP selectionEdward Thomson2021-11-112-18/+18
| | | | | | | | Move WinHTTP selection into its own cmake module.
| * cmake: refactor libssh2 selectionEdward Thomson2021-11-112-26/+42
| | | | | | | | Move SSH selection into its own cmake module.
| * cmake: refactor regex selectionEdward Thomson2021-11-112-52/+52
| | | | | | | | Move regex selection into its own cmake module.
| * cmake: refactor http_parser selectionEdward Thomson2021-11-112-20/+21
| | | | | | | | Move http_parser selection into its own cmake module.
| * cmake: HTTP_Parser is now HTTPParserEdward Thomson2021-11-112-1/+1
| |
| * cmake: qsort detection in features.hEdward Thomson2021-11-113-20/+15
| |
| * cmake: move test enablement into test cmakeEdward Thomson2021-11-112-1/+2
| |
| * cmake: reorganize fileEdward Thomson2021-11-111-13/+5
| |
| * cmake: move fuzzer args to the fuzzer's cmakeEdward Thomson2021-11-112-15/+5
| |
| * cmake: move deprecation definition to src/Edward Thomson2021-11-112-4/+4
| | | | | | | | | | There's no need to add the deprecation at the top-level. Our tests add deprecation explicitly.
| * cmake: move cflag defaults into a separate moduleEdward Thomson2021-11-112-171/+171
| |
| * cmake: USE_SSH is not on by defaultEdward Thomson2021-11-113-21/+21
| |
| * cmake: standardize USE_WINHTTPEdward Thomson2021-11-113-4/+4
| | | | | | | | | | WinHTTP can now be disabled with `USE_WINHTTP=OFF` instead of `WINHTTP=OFF` to better support the other cmake semantics.
| * cmake: standardize USE_THREADS and USE_NSECEdward Thomson2021-11-116-36/+33
| | | | | | | | | | | | | | | | Threading can now be disabled with `USE_THREADS=OFF` instead of `THREADSAFE=OFF` to better support the other cmake semantics. Nanosecond support is the default _if_ we can detect it. This should be our default always - like threads - and people can opt out explicitly.
* | Merge pull request #6111 from libgit2/ethomson/str_freeEdward Thomson2021-11-111-7/+0
|\ \ | |/ |/| str: git_str_free is never a function
| * str: git_str_free is never a functionEdward Thomson2021-11-111-7/+0
|/
* Merge pull request #6104 from libgit2/ethomson/pathEdward Thomson2021-11-11123-3769/+4042
|\ | | | | path: refactor utility path functions
| * win32: include correct path headerethomson/pathEdward Thomson2021-11-094-4/+4
| |
| * fs_path: remove now-unused validation functionsEdward Thomson2021-11-092-68/+0
| |
| * fs_path: add length with suffix validationEdward Thomson2021-11-094-3/+30
| |
| * path: use new length validation functionsEdward Thomson2021-11-0910-20/+36
| |
| * path: length validation respecting core.longpathsEdward Thomson2021-11-093-18/+69
| | | | | | | | | | Teach `git_path_is_valid` to respect `core.longpaths`. Add helper methods to validate length and set the error message appropriately.
| * path: introduce `git_path_str_is_valid`Edward Thomson2021-11-095-18/+28
| | | | | | | | | | Add a `git_str` based validity check; the existing `git_path_is_valid` defers to it.
View Lorry Controller Status