Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | date: rfc2822 formatting uses a `git_buf` instead of a static stringethomson/date | Edward Thomson | 2021-11-19 | 5 | -39/+39 |
| | |||||
* | date: make it a proper `git_date` utility class | Edward Thomson | 2021-11-18 | 7 | -32/+47 |
| | | | | Instead of `git__date`, just use `git_date`. | ||||
* | Merge pull request #6120 from libgit2/ethomson/cmake_test | Edward Thomson | 2021-11-17 | 3 | -3/+2 |
|\ | | | | | cmake: re-enable WinHTTP | ||||
| * | cmake: use WINHTTP when USE_WINHTTP is specifiedethomson/cmake_test | Edward Thomson | 2021-11-17 | 1 | -1/+1 |
| | | |||||
| * | cmake: enable testing at the top level | Edward Thomson | 2021-11-17 | 2 | -2/+1 |
|/ | | | | | | | Ensure that we `enable_testing()` at the top-level CMakeLists.txt or else we'll need to navigate within the build directory to the correct place in the hierarchy to run `ctest`. Now we can `ctest` at the top-level again. | ||||
* | Merge pull request #6119 from libgit2/ethomson/tag_valid | Edward Thomson | 2021-11-16 | 1 | -0/+2 |
|\ | | | | | tag: set validity to 0 by default | ||||
| * | tag: set validity to 0 by defaultethomson/tag_valid | Edward Thomson | 2021-11-16 | 1 | -0/+2 |
|/ | | | | | `git_tag_name_is_valid` needs to set validity to 0 when it short-circuits. | ||||
* | cmake: better explain why headertests exists | Edward Thomson | 2021-11-16 | 1 | -3/+8 |
| | |||||
* | Make enum in src,tests and examples C90 compliant by removing trailing comma. | Peter Pettersson | 2021-11-15 | 37 | -46/+46 |
| | |||||
* | ntmlclient: make enum C90 compliant by removing trailing comma | Peter Pettersson | 2021-11-15 | 2 | -6/+6 |
| | |||||
* | Make enum in includes C90 compliant by removing trailing comma. | Peter Pettersson | 2021-11-15 | 38 | -72/+72 |
| | |||||
* | Add target for testing libgit2 headers | Peter Pettersson | 2021-11-15 | 2 | -1/+26 |
| | |||||
* | Merge pull request #6114 from libgit2/ethomson/cmake5 | Edward Thomson | 2021-11-14 | 30 | -866/+747 |
|\ | | | | | cmake: further refactorings | ||||
| * | cmake: move sha1 source selection into CMakeLists.txt | Edward Thomson | 2021-11-14 | 2 | -12/+17 |
| | | | | | | | | | | The select hashes module selects the hash; the CMakeLists.txt selects the files to implement it. | ||||
| * | cmake: use a string not a boolean for LIBGIT2_FILENAME | Edward Thomson | 2021-11-14 | 1 | -1/+1 |
| | | |||||
| * | cmake: refactor global variables | Edward Thomson | 2021-11-14 | 12 | -59/+58 |
| | | | | | | | | | | Update the global variables `LIBGIT2_OBJECTS` to `LIBGIT2_DEPENDENCY_OBJECTS` for clarity and consistency. | ||||
| * | cmake: reformat modules | Edward Thomson | 2021-11-14 | 20 | -812/+689 |
|/ | | | | Apply the standard project cmake formatting to the modules. | ||||
* | Merge pull request #6116 from ↵ | Edward Thomson | 2021-11-14 | 1 | -1/+1 |
|\ | | | | | | | lhchavez/drop-volatile-qualifier-in-atomic-exchange | ||||
| * | Fix a gcc 11 warning in src/thread.h | lhchavez | 2021-11-14 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When building under gcc 11, there is a warning about an incompatible pointer type, since [`__atomic_exchange`](https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html) does not take `volatile` pointers: ``` In file included from ../src/common.h:81, from ../src/transports/winhttp.c:8: ../src/thread-utils.h: In function ‘git___swap’: ../src/thread-utils.h:168:9: warning: argument 3 of ‘__atomic_exchange’ discards ‘volatile’ qualifier [-Wincompatible-pointer-types] 168 | __atomic_exchange(ptr, &newval, &foundval, __ATOMIC_SEQ_CST); | ^~~~~~~~~~~~~~~~~ ``` This change drops the `volatile` qualifier so that the pointer type matches what `__atomic_exchange` expects. | ||||
* | | Merge pull request #6115 from lhchavez/fix-indentation-threadstate | Edward Thomson | 2021-11-14 | 1 | -2/+2 |
|\ \ | |/ |/| | |||||
| * | Fix a gcc 11 warning in src/threadstate.c | lhchavez | 2021-11-14 | 1 | -2/+2 |
|/ | | | | | | | | | | | | | | | | | | | | When building under gcc 11, there is a warning about a misaligned guard clause because there were mixed spaces and tabs: ``` [128/634] Building C object src/CMakeFiles/git2internal.dir/threadstate.c.o ../src/threadstate.c: In function ‘threadstate_dispose’: ../src/threadstate.c:39:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] 39 | if (threadstate->error_t.message != git_str__initstr) | ^~ ../src/threadstate.c:41:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ 41 | threadstate->error_t.message = NULL; | ^~~~~~~~~~~ ../src/threadstate.c: At top level: ``` This change indents the code with tabs for consistency with the rest of the code, which makes the warning go away. | ||||
* | Merge pull request #6113 from libgit2/ethomson/cmake3 | Edward Thomson | 2021-11-11 | 56 | -111/+570 |
|\ | | | | | Add missing-declarations warning globally | ||||
| * | cmake: move missing-declarations warning to top-level | Edward Thomson | 2021-11-11 | 2 | -2/+1 |
| | | | | | | | | | | We should enforce declarations throughout the code-base, including examples, fuzzers and tests, not just in the `src` tree. | ||||
| * | tests: include function declarations | Edward Thomson | 2021-11-11 | 5 | -4/+13 |
| | | |||||
| * | test: correct test names | Edward Thomson | 2021-11-11 | 3 | -3/+3 |
| | | |||||
| * | tests: declare functions statically where appropriate | Edward Thomson | 2021-11-11 | 34 | -60/+442 |
| | | |||||
| * | clar: declare summary functions as static | Edward Thomson | 2021-11-11 | 1 | -5/+5 |
| | | |||||
| * | example: declare print_usage function | Edward Thomson | 2021-11-11 | 1 | -1/+1 |
| | | |||||
| * | examples: remove unused function | Edward Thomson | 2021-11-11 | 1 | -15/+0 |
| | | |||||
| * | fuzzers: declare static functions as static | Edward Thomson | 2021-11-11 | 2 | -4/+4 |
| | | |||||
| * | fuzzers: declare standalone functions | Edward Thomson | 2021-11-11 | 9 | -2/+29 |
| | | |||||
| * | tests: declare trace handler as static | Edward Thomson | 2021-11-11 | 1 | -1/+1 |
| | | |||||
| * | tests: include test declarations for old gcc | Edward Thomson | 2021-11-11 | 1 | -1/+9 |
| | | | | | | | | | | | | | | Older versions of gcc do not believe that we've adequately declared our test functions. Include `clar_suite.h` conditionally for those old versions. Do not do this on newer compilers to avoid unnecessary recompilation of the entire suite when we add or remove a test function. | ||||
| * | clar: emit `clar_suite.h` with test declarations | Edward Thomson | 2021-11-11 | 1 | -13/+62 |
|/ | | | | | | | We may want to have test function declarations; produce a header file with (only) the test declarations. Update clar to avoid overwriting the file unnecessarily to avoid bumping timestamps and potentially recompiling unnecessarily. | ||||
* | Merge pull request #6112 from libgit2/ethomson/cmake3 | Edward Thomson | 2021-11-11 | 20 | -428/+422 |
|\ | | | | | cmake refactorings | ||||
| * | cmake: refactor zlib selectionethomson/cmake3 | Edward Thomson | 2021-11-11 | 2 | -33/+35 |
| | | | | | | | | Move zlib selection into its own cmake module. | ||||
| * | cmake: refactor WinHTTP selection | Edward Thomson | 2021-11-11 | 2 | -18/+18 |
| | | | | | | | | Move WinHTTP selection into its own cmake module. | ||||
| * | cmake: refactor libssh2 selection | Edward Thomson | 2021-11-11 | 2 | -26/+42 |
| | | | | | | | | Move SSH selection into its own cmake module. | ||||
| * | cmake: refactor regex selection | Edward Thomson | 2021-11-11 | 2 | -52/+52 |
| | | | | | | | | Move regex selection into its own cmake module. | ||||
| * | cmake: refactor http_parser selection | Edward Thomson | 2021-11-11 | 2 | -20/+21 |
| | | | | | | | | Move http_parser selection into its own cmake module. | ||||
| * | cmake: HTTP_Parser is now HTTPParser | Edward Thomson | 2021-11-11 | 2 | -1/+1 |
| | | |||||
| * | cmake: qsort detection in features.h | Edward Thomson | 2021-11-11 | 3 | -20/+15 |
| | | |||||
| * | cmake: move test enablement into test cmake | Edward Thomson | 2021-11-11 | 2 | -1/+2 |
| | | |||||
| * | cmake: reorganize file | Edward Thomson | 2021-11-11 | 1 | -13/+5 |
| | | |||||
| * | cmake: move fuzzer args to the fuzzer's cmake | Edward Thomson | 2021-11-11 | 2 | -15/+5 |
| | | |||||
| * | cmake: move deprecation definition to src/ | Edward Thomson | 2021-11-11 | 2 | -4/+4 |
| | | | | | | | | | | There's no need to add the deprecation at the top-level. Our tests add deprecation explicitly. | ||||
| * | cmake: move cflag defaults into a separate module | Edward Thomson | 2021-11-11 | 2 | -171/+171 |
| | | |||||
| * | cmake: USE_SSH is not on by default | Edward Thomson | 2021-11-11 | 3 | -21/+21 |
| | | |||||
| * | cmake: standardize USE_WINHTTP | Edward Thomson | 2021-11-11 | 3 | -4/+4 |
| | | | | | | | | | | WinHTTP can now be disabled with `USE_WINHTTP=OFF` instead of `WINHTTP=OFF` to better support the other cmake semantics. | ||||
| * | cmake: standardize USE_THREADS and USE_NSEC | Edward Thomson | 2021-11-11 | 6 | -36/+33 |
| | | | | | | | | | | | | | | | | Threading can now be disabled with `USE_THREADS=OFF` instead of `THREADSAFE=OFF` to better support the other cmake semantics. Nanosecond support is the default _if_ we can detect it. This should be our default always - like threads - and people can opt out explicitly. |