summaryrefslogtreecommitdiff
path: root/src/path.c
Commit message (Collapse)AuthorAgeFilesLines
* Make sure to always include "common.h" firstPatrick Steinhardt2017-07-031-1/+2
| | | | | | | | | | | | | | | | | | | | | | Next to including several files, our "common.h" header also declares various macros which are then used throughout the project. As such, we have to make sure to always include this file first in all implementation files. Otherwise, we might encounter problems or even silent behavioural differences due to macros or defines not being defined as they should be. So in fact, our header and implementation files should make sure to always include "common.h" first. This commit does so by establishing a common include pattern. Header files inside of "src" will now always include "common.h" as its first other file, separated by a newline from all the other includes to make it stand out as special. There are two cases for the implementation files. If they do have a matching header file, they will always include this one first, leading to "common.h" being transitively included as first file. If they do not have a matching header file, they instead include "common.h" as first file themselves. This fixes the outlined problems and will become our standard practice for header and source files inside of the "src/" from now on.
* path: only set dotgit flags when configs were readPatrick Steinhardt2017-06-081-4/+5
|
* path: short-circuit `git_path_apply_relative` on errorPatrick Steinhardt2017-04-041-2/+2
| | | | | | | Short-circuit the call to `git_path_resolve_relative` in case `git_buf_joinpath` returns an error. While this does not fix any immediate errors, the resulting code is easier to read and handles potential new error conditions raised by `git_buf_joinpath`.
* path: handle error returned by `git_buf_joinpath`Patrick Steinhardt2017-04-041-1/+2
| | | | | | | | In the `_check_dir_contents` function, we first allocate memory for joining the directory and subdirectory together and afterwards use `git_buf_joinpath`. While this function in fact should not fail as memory is already allocated, err on the safe side and check for returned errors.
* path: ensure dirname on Win32 prefix always has a trailing '/'Patrick Steinhardt2017-02-081-7/+15
| | | | | | | | | | When calling `git_path_dirname_r` on a Win32 prefix, e.g. a drive or network share prefix, we always want to return the trailing '/'. This does not work currently when passing in a path like 'C:', where the '/' would not be appended correctly. Fix this by appending a '/' if we try to normalize a Win32 prefix and there is no trailing '/'.
* path: get correct dirname for Windows rootPatrick Steinhardt2017-02-081-0/+3
| | | | | | | | | | | | Getting the dirname of a filesystem root should return the filesystem root itself. E.g. the dirname of "/" is always "/". On Windows, we emulate this behavior and as such, we should return e.g. "C:/" if calling dirname on "C:/". But we currently fail to do so and instead return ".", as we do not check if we actually have a Windows prefix before stripping off the last directory component. Fix this by calling out to `win32_prefix_length` immediately after stripping trailing slashes, returning early if we have a prefix.
* path: extract `win32_path_prefix` functionPatrick Steinhardt2017-02-081-23/+33
| | | | | | Extract code which determines if a path is at a Windows system's root. This incluses drive prefixes (e.g. "C:\") as well as network computer names (e.g. "//computername/").
* giterr_set: consistent error messagesEdward Thomson2016-12-291-15/+15
| | | | | | | | Error messages should be sentence fragments, and therefore: 1. Should not begin with a capital letter, 2. Should not conclude with punctuation, and 3. Should not end a sentence and begin a new one
* path: remove unused local variablePatrick Steinhardt2016-12-121-1/+0
|
* refdb: bubble up locked files on the read sideCarlos Martín Nieto2016-11-141-0/+4
| | | | | | On Windows we can find locked files even when reading a reference or the packed-refs file. Bubble up the error in this case as well to allow callers on Windows to retry more intelligently.
* path: pass string instead of git_buf to giterr_setPatrick Steinhardt2016-11-141-1/+1
|
* Patch parsing from patch filesEdward Thomson2016-05-261-0/+19
|
* Introduce `git_path_common_dirlen`Edward Thomson2016-03-241-0/+14
|
* path: use GITERR_CHECK_ALLOC_BUF to verify passed in bufferPatrick Steinhardt2016-02-231-2/+1
|
* index: allow read of index w/ illegal entriesEdward Thomson2016-02-171-1/+6
| | | | | | | | | Allow `git_index_read` to handle reading existing indexes with illegal entries. Allow the low-level `git_index_add` to add properly formed `git_index_entry`s even if they contain paths that would be illegal for the current filesystem (eg, `AUX`). Continue to disallow `git_index_add_bypath` from adding entries that are illegal universally illegal (eg, `.git`, `foo/../bar`).
* Fix a couple function signaturesThomas Edvalson2015-12-141-1/+1
|
* core::mkdir tests: ensure we don't stomp symlinks in mkdirEdward Thomson2015-09-171-0/+11
| | | | | In `mkdir` and `mkdir_r`, ensure that we don't try to remove symlinks that are in our way.
* diriter: don't double '/' on posixEdward Thomson2015-09-131-1/+5
| | | | | | The canonical directory path of the root directory of a volume on POSIX already ends in a slash (eg, `/`). This is true only at the root. Do not add a slash to paths in this case.
* diriter: don't double '/' on WindowsEdward Thomson2015-09-131-1/+5
| | | | | | The canonical directory path of the root directory of a volume on windows already ends in a slash (eg, `c:/`). This is true only at the volume root. Do not add a slash to paths in this case.
* Fix duplicate basenames to support older VSJohn Haley2015-08-051-1/+1
| | | | | | | With Visual Studio versions 2008 and older they ignore the full path to files and only check the basename of the file to find a collision. Additionally, having duplicate basenames can break other build tools like GYP. This fixes https://github.com/libgit2/libgit2/issues/3356
* Merge pull request #3307 from libgit2/cmn/submodule-backslashEdward Thomson2015-07-241-0/+16
|\ | | | | Normalize submodule urls before looking at them
| * submodule, path: extract slash conversioncmn/submodule-backslashCarlos Martín Nieto2015-07-131-0/+16
| | | | | | | | Extract the backslash-to-slash conversion into a helper function.
* | Make libgit2 work on Windows Vista againSven Strickroth2015-07-221-3/+8
|/ | | | | | (fixes issue #3316) Signed-off-by: Sven Strickroth <email@cs-ware.de>
* buffer: don't allow growing borrowed buffersCarlos Martín Nieto2015-06-241-2/+2
| | | | | | | | | | When we don't own a buffer (asize=0) we currently allow the usage of grow to copy the memory into a buffer we do own. This muddles the meaning of grow, and lets us be a bit cavalier with ownership semantics. Don't allow this any more. Usage of grow should be restricted to buffers which we know own their own memory. If unsure, we must not attempt to modify it.
* Fixed Xcode 6.1 build warningsPierre-Olivier Latour2015-06-171-1/+1
|
* Fixed Xcode 6.1 build warningsPierre-Olivier Latour2015-06-151-2/+2
|
* path: remove unnecessary readdir_r usagecmn/readdirCarlos Martín Nieto2015-06-151-4/+3
| | | | | | Arguably all uses of readdir_r are unnecessary, but in this case especially so, as the directory handle only exists within this function, so we don't race with anybody.
* Fix memory leak on windows in diriter.Jeff Hostetler2015-06-121-0/+2
|
* Merge pull request #3165 from ethomson/downcaseCarlos Martín Nieto2015-06-081-1/+1
|\ | | | | Downcase
| * git__tolower: a tolower() that isn't dumbEdward Thomson2015-05-291-1/+1
| | | | | | | | | | | | | | | | Some brain damaged tolower() implementations appear to want to take the locale into account, and this may require taking some insanely aggressive lock on the locale and slowing down what should be the most trivial of trivial calls for people who just want to downcase ASCII.
* | path: error out if the callback returns an errorcmn/foreach-cancel-looseCarlos Martín Nieto2015-06-061-2/+4
|/ | | | | | | When the callback returns an error, we should stop immediately. This broke when trying to make sure we pass specific errors up the chain. This broke cancelling out of the loose backend's foreach.
* path: don't let direach overwrite the callback's error messageCarlos Martín Nieto2015-05-151-1/+3
| | | | | | | | | | This function deals with functions doing IO which means the amount of errors that can happen is quit large. It does not help if it always ovewrites the underlying error message with a less understandable version of "something went wrong". Instead, only use this generic message if there was no error set by the callback.
* diriter: actually use iconv on macEdward Thomson2015-05-011-2/+3
|
* git_buf_put_w: introduce utf16->utf8 conversionEdward Thomson2015-05-011-23/+4
|
* git_path_diriter: use FindFirstFile in win32Edward Thomson2015-05-011-2/+186
| | | | | | | Using FindFirstFile and FindNextFile in win32 allows us to use the directory information that is returned, instead of us having to get the file attributes all over again, which is a distinct cost savings on win32.
* git_path_diriter: next shouldn't take path ptrEdward Thomson2015-05-011-12/+15
| | | | | | | | The _next method shouldn't take a path pointer (and a path_len pointer) as 100% of current users use the full path and ignore the filename. Plus let's add some docs and a unit test.
* git_path_dirload_with_stat: moved to fs_iteratorEdward Thomson2015-05-011-127/+0
|
* git_path_dirload_with_stat: use git_path_diriterEdward Thomson2015-05-011-123/+51
|
* git_path_dirload: use git_path_diriterEdward Thomson2015-05-011-75/+112
|
* git_path: introduce 'git_path_diriter'Edward Thomson2015-05-011-0/+130
| | | | | Introduce a new `git_path_diriter` that can iterate directories efficiently for each platform.
* ISO C90 forbids mixed declarations and codeJozef Matula2015-04-081-4/+4
| | | | | GIT_UNUSED() macro generates code therefore it should be used after variable declarations.
* repository: Introduce "reserved names"Edward Thomson2015-02-271-19/+20
| | | | | | | A repository can have multiple "reserved names" now, not just a single "short name" for the repository folder itself. Refactor to include a git_repository__reserved_names that returns all the reserved names for a repository.
* Make our overflow check look more like gcc/clang'sEdward Thomson2015-02-131-25/+18
| | | | | | | | | Make our overflow checking look more like gcc and clang's, so that we can substitute it out with the compiler instrinsics on platforms that support it. This means dropping the ability to pass `NULL` as an out parameter. As a result, the macros also get updated to reflect this as well.
* allocations: test for overflow of requested sizeEdward Thomson2015-02-121-14/+50
| | | | | Introduce some helper macros to test integer overflow from arithmetic and set error message appropriately.
* git_path_join_unrooted: return base lenEdward Thomson2015-01-201-11/+16
| | | | | | | The documentation for `git_path_join_unrooted` states that the base length will be returned, so that consumers like checkout know where to start creating directories instead of always creating directories at the directory root.
* COM0 is a valid path, although Windows Explorer does not allow to create thisLinquize2014-12-191-1/+1
|
* Introduce core.protectHFS and core.protectNTFSEdward Thomson2014-12-171-31/+82
| | | | | | Validate HFS ignored char ".git" paths when `core.protectHFS` is specified. Validate NTFS invalid ".git" paths when `core.protectNTFS` is specified.
* path: Use UTF8 iteration for HFS charsVicent Marti2014-12-161-81/+45
|
* checkout: disallow bad paths on HFSEdward Thomson2014-12-161-0/+93
| | | | | | | | HFS filesystems ignore some characters like U+200C. When these characters are included in a path, they will be ignored for the purposes of comparison with other paths. Thus, if you have a ".git" folder, a folder of ".git<U+200C>" will also match. Protect our ".git" folder by ensuring that ".git<U+200C>" and friends do not match it.
* checkout: disallow bad paths on win32Edward Thomson2014-12-161-0/+148
| | | | | | | | | | | | | | | Disallow: 1. paths with trailing dot 2. paths with trailing space 3. paths with trailing colon 4. paths that are 8.3 short names of .git folders ("GIT~1") 5. paths that are reserved path names (COM1, LPT1, etc). 6. paths with reserved DOS characters (colons, asterisks, etc) These paths would (without \\?\ syntax) be elided to other paths - for example, ".git." would be written as ".git". As a result, writing these paths literally (using \\?\ syntax) makes them hard to operate with from the shell, Windows Explorer or other tools. Disallow these.
View Lorry Controller Status