summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* diff: treat binary patches with no data specialethomson/diff-read-empty-binaryEdward Thomson2016-09-054-19/+61
| | | | | | When creating and printing diffs, deal with binary deltas that have binary data specially, versus diffs that have a binary file but lack the actual binary data.
* diff_print: change test for skipping binary printingEdward Thomson2016-09-021-3/+3
| | | | | | | | | | | | Instead of skipping printing a binary diff when there is no data, skip printing when we have a status of `UNMODIFIED`. This is more in-line with our internal data model and allows us to expand the notion of binary data. In the future, there may have no data because the files were unmodified (there was no data to produce) or it may have no data because there was no data given to us in a patch. We want to treat these cases separately.
* patch: error on diff callback failureEdward Thomson2016-09-021-0/+3
|
* patch_generate: only calculate binary diffs if requestedPatrick Steinhardt2016-09-011-14/+18
| | | | | | | | | | | | | | | | When generating diffs for binary files, we load and decompress the blobs in order to generate the actual diff, which can be very costly. While we cannot avoid this for the case when we are called with the `GIT_DIFF_SHOW_BINARY` flag, we do not have to load the blobs in the case where this flag is not set, as the caller is expected to have no interest in the actual content of binary files. Fix the issue by only generating a binary diff when the caller is actually interested in the diff. As libgit2 uses heuristics to determine that a blob contains binary data by inspecting its size without loading from the ODB, this saves us quite some time when diffing in a repository with binary files.
* git_checkout_tree options fixStefan Huber2016-08-301-1/+1
| | | | | | | | According to the reference the git_checkout_tree and git_checkout_head functions should accept NULL in the opts field This was broken since the opts field was dereferenced and thus lead to a crash.
* Merge pull request #3900 from pks-t/pks/http-close-substream-on-connectPatrick Steinhardt2016-08-291-0/+3
|\ | | | | transports: http: set substream as disconnected after closing
| * transports: http: reset `connected` flag when closing transportPatrick Steinhardt2016-08-171-0/+2
| |
| * transports: http: reset `connected` flag when re-connecting transportPatrick Steinhardt2016-08-171-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | When calling `http_connect` on a subtransport whose stream is already connected, we first close the stream in case no keep-alive is in use. When doing so, we do not reset the transport's connection state, though. Usually, this will do no harm in case the subsequent connect will succeed. But when the connection fails we are left with a substransport which is tagged as connected but which has no valid stream attached. Fix the issue by resetting the subtransport's connected-state when closing its stream in `http_connect`.
* | Teach `git_patch_from_diff` about parsed diffsethomson/patch_from_diffEdward Thomson2016-08-249-7/+50
| | | | | | | | | | Ensure that `git_patch_from_diff` can return the patch for parsed diffs, not just generate a patch for a generated diff.
* | filesystem_iterator: fixed double free on errorJason Haslam2016-08-221-5/+3
| |
* | Merge pull request #3837 from novalis/dturner/indexv4Edward Thomson2016-08-174-29/+179
|\ \ | | | | | | Support index v4
| * | index: support index v4David Turner2016-08-102-29/+120
| | | | | | | | | | | | | | | | | | | | | Support reading and writing index v4. Index v4 uses a very simple compression scheme for pathnames, but is otherwise similar to index v3. Signed-off-by: David Turner <dturner@twitter.com>
| * | varint: Add varint encoding/decodingDavid Turner2016-08-102-0/+59
| |/ | | | | | | | | | | | | This code is ported from git.git Signed-off-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: David Turner <dturner@twopensource.com>
* | Merge pull request #3895 from pks-t/pks/negate-basename-in-subdirsEdward Thomson2016-08-171-16/+45
|\ \ | |/ |/| ignore: allow unignoring basenames in subdirectories
| * ignore: allow unignoring basenames in subdirectoriesPatrick Steinhardt2016-08-121-16/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The .gitignore file allows for patterns which unignore previous ignore patterns. When unignoring a previous pattern, there are basically three cases how this is matched when no globbing is used: 1. when a previous file has been ignored, it can be unignored by using its exact name, e.g. foo/bar !foo/bar 2. when a file in a subdirectory has been ignored, it can be unignored by using its basename, e.g. foo/bar !bar 3. when all files with a basename are ignored, a specific file can be unignored again by specifying its path in a subdirectory, e.g. bar !foo/bar The first problem in libgit2 is that we did not correctly treat the second case. While we verified that the negative pattern matches the tail of the positive one, we did not verify if it only matches the basename of the positive pattern. So e.g. we would have also negated a pattern like foo/fruz_bar !bar Furthermore, we did not check for the third case, where a basename is being unignored in a certain subdirectory again. Both issues are fixed with this commit.
* | stransport: do not use `git_stream_free` on uninitialized stransportPatrick Steinhardt2016-08-091-1/+3
| | | | | | | | | | | | | | | | | | | | | | When failing to initialize a new stransport stream, we try to release already allocated memory by calling out to `git_stream_free`, which in turn called out to the stream's `free` function pointer. As we only initialize the function pointer later on, this leads to a `NULL` pointer exception. Furthermore, plug another memory leak when failing to create the SSL context.
* | Merge pull request #3887 from libgit2/ethomson/empty_blobCarlos Martín Nieto2016-08-081-5/+0
|\ \ | | | | | | odb: only provide the empty tree
| * | odb: only provide the empty treeEdward Thomson2016-08-051-5/+0
| | | | | | | | | | | | | | | | | | | | | Only provide the empty tree internally, which matches git's behavior. If we provide the empty blob then any users trying to write it with libgit2 would omit it from actually landing in the odb, which appear to git proper as a broken repository (missing that object).
* | | Merge pull request #3890 from pks-t/pks/stransport-static-linkageEdward Thomson2016-08-081-8/+8
|\ \ \ | |/ / |/| | stransport: make internal functions static
| * | stransport: make internal functions staticPatrick Steinhardt2016-08-081-8/+8
| | |
* | | SecureTransport: handle NULL trust on successcmn/copypeertrust-nullCarlos Martín Nieto2016-08-051-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | The `SSLCopyPeerTrust` call can succeed but fail to return a trust object if it can't load the certificate chain and thus cannot check the validity of a certificate. This can lead to us calling `CFRelease` on a `NULL` trust object, causing a crash. Handle this by returning ECERTIFICATE.
* | | apply: fix warning when initializing patch imagesPatrick Steinhardt2016-08-051-1/+1
| | |
* | | pool: provide macro to statically initialize git_poolPatrick Steinhardt2016-08-051-0/+5
| |/ |/|
* | odb: only freshen pack files every 2 secondsethomson/refresh_objectsEdward Thomson2016-08-045-10/+23
| | | | | | | | | | | | Since writing multiple objects may all already exist in a single packfile, avoid freshening that packfile repeatedly in a tight loop. Instead, only freshen pack files every 2 seconds.
* | odb: freshen existing objects when writingEdward Thomson2016-08-045-3/+96
| | | | | | | | | | | | When writing an object, we calculate its OID and see if it exists in the object database. If it does, we need to freshen the file that contains it.
* | Merge pull request #3877 from libgit2/ethomson/paths_initCarlos Martín Nieto2016-08-042-52/+41
|\ \ | | | | | | sysdir: don't assume an empty dir is uninitialized
| * | sysdir: use the standard `init` patternethomson/paths_initEdward Thomson2016-08-042-52/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't try to determine when sysdirs are uninitialized. Instead, simply initialize them all at `git_libgit2_init` time and never try to reinitialize, except when consumers explicitly call `git_sysdir_set`. Looking at the buffer length is especially problematic, since there may no appropriate path for that value. (For example, the Windows-specific programdata directory has no value on non-Windows machines.) Previously we would continually trying to re-lookup these values, which could get racy if two different threads are each calling `git_sysdir_get` and trying to lookup / clear the value simultaneously.
* | | Merge pull request #3869 from richardipsum/fix-outdated-commentEdward Thomson2016-08-041-3/+3
|\ \ \ | | | | | | | | Fix outdated comment
| * | | Make comment conform to style guideRichard Ipsum2016-07-231-1/+2
| | | | | | | | | | | | | | | | Style guide says // style comments should be avoided.
| * | | Fix outdated commentRichard Ipsum2016-07-231-2/+1
| | | | | | | | | | | | | | | | SSH transport seems to be supported now.
* | | | Merge pull request #3850 from wildart/custom-tlsEdward Thomson2016-08-043-6/+1
|\ \ \ \ | | | | | | | | | | Enable https transport for custom TLS streams
| * | | | remove conditions that prevent use of custom TLS streamwildart2016-07-063-6/+1
| | | | |
* | | | | Merge pull request #3879 from libgit2/ethomson/mwindow_initEdward Thomson2016-08-044-26/+12
|\ \ \ \ \ | |_|_|_|/ |/| | | | mwindow: init mwindow files in git_libgit2_init
| * | | | mwindow: init mwindow files in git_libgit2_initethomson/mwindow_initEdward Thomson2016-08-044-26/+12
| | |_|/ | |/| |
* | | | git_diff_file: move `id_abbrev`ethomson/diff_fileEdward Thomson2016-08-031-3/+3
|/ / / | | | | | | | | | | | | Move `id_abbrev` to a more reasonable place where it packs more nicely (before anybody starts using it).
* | | Merge pull request #3865 from libgit2/ethomson/leaksEdward Thomson2016-08-028-86/+113
|\ \ \ | | | | | | | | Fix leaks, some warnings and an error
| * | | crlf: set a safe crlf defaultEdward Thomson2016-07-241-0/+1
| | | |
| * | | repository: don't cast to `int` for no reasonEdward Thomson2016-07-241-4/+4
| | | | | | | | | | | | | | | | | | | | And give it a default so that some compilers don't (unnecessarily) complain.
| * | | index: cast to avoid warningEdward Thomson2016-07-241-2/+2
| | | |
| * | | packbuilder: `size_t` all the thingsEdward Thomson2016-07-243-77/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After 1cd65991, we were passing a pointer to an `unsigned long` to a function that now expected a pointer to a `size_t`. These types differ on 64-bit Windows, which means that we trash the stack. Use `size_t`s in the packbuilder to avoid this.
| * | | apply: safety check files that dont end with eolEdward Thomson2016-07-241-1/+4
| | | |
| * | | apply: check allocation properlyEdward Thomson2016-07-241-1/+1
| | | |
| * | | apply: compare preimage to imageEdward Thomson2016-07-241-1/+1
| | |/ | |/| | | | | | | Compare the preimage to the image; don't compare the preimage to itself.
* | | remote: Handle missing config values when deleting a remoteDavid Turner2016-07-151-4/+10
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Somehow I ended up with the following in my ~/.gitconfig: [branch "master"] remote = origin merge = master rebase = true I assume something went crazy while I was running the git.git tests some time ago, and that I never noticed until now. This is not a good configuration, but it shouldn't cause problems. But it does. Specifically, if you have this in your config, and you perform the following set of actions: create a remote fetch from that remote create a branch off of the remote master branch called "master" delete the branch delete the remote The remote delete fails with the message "Could not find key 'branch.master.rebase' to delete". This is because it's iterating over the config entries (including the ones in the global config) and believes that there is a master branch which must therefore have these config keys. https://github.com/libgit2/libgit2/issues/3856
* | Merge pull request #3851 from txdv/get-user-agentEdward Thomson2016-07-051-0/+8
|\ \ | | | | | | Add get user agent functionality.
| * | Add get user agent functionality.Andrius Bentkus2016-07-051-0/+8
| |/
* | Merge pull request #3846 from rkrp/fix_bug_parsing_int64minEdward Thomson2016-07-051-3/+3
|\ \ | |/ |/| Fixed bug while parsing INT64_MIN
| * Fixed bug while parsing INT64_MINKrishna Ram Prakash R2016-06-291-3/+3
| |
* | Merge pull request #3836 from joshtriplett/cleanup-find_repoEdward Thomson2016-07-011-22/+30
|\ \ | | | | | | find_repo: Clean up and simplify logic
| * | find_repo: Clean up and simplify logicJosh Triplett2016-06-241-22/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | find_repo had a complex loop and heavily nested conditionals, making it difficult to follow. Simplify this as much as possible: - Separate assignments from conditionals. - Check the complex loop condition in the only place it can change. - Break out of the loop on error, rather than going through the rest of the loop body first. - Handle error cases by immediately breaking, rather than nesting conditionals. - Free repo_link unconditionally on the way out of the function, rather than in multiple places. - Add more comments on the remaining complex steps.
View Lorry Controller Status