summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* yoethomson/util3Edward Thomson2021-11-102-330/+124
|
* checkpointEdward Thomson2021-11-103-126/+163
|
* fixup! refactor: make util an object libraryEdward Thomson2021-11-101-20/+15
|
* fixup! refactor: make util an object libraryEdward Thomson2021-11-101-0/+0
|
* refactor: make util an object libraryEdward Thomson2021-11-1051-243/+339
| | | | | | Instead of simply including the utility files directly, make them a cmake object library for easy reusability between other projects within libgit2.
* refactor: move utility functions into util directoryEdward Thomson2021-11-1099-431/+434
|
* refactor: `src` is now `src/libgit2`Edward Thomson2021-11-10358-422/+431
| | | | Adding an additional hierarchy allows us to split out utility functions.
* cmake: HTTP_Parser is now HTTPParserEdward Thomson2021-11-101-1/+1
|
* cmake: qsort detection in features.hEdward Thomson2021-11-103-20/+15
|
* cmake: move src cflags into defaultEdward Thomson2021-11-101-2/+0
|
* cmake: move deprecation definition to src/Edward Thomson2021-11-101-0/+4
| | | | | There's no need to add the deprecation at the top-level. Our tests add deprecation explicitly.
* cmake: standardize USE_WINHTTPEdward Thomson2021-11-101-1/+1
| | | | | WinHTTP can now be disabled with `USE_WINHTTP=OFF` instead of `WINHTTP=OFF` to better support the other cmake semantics.
* cmake: standardize USE_THREADS and USE_NSECethomson/cmake2Edward Thomson2021-11-092-5/+5
| | | | | | | | Threading can now be disabled with `USE_THREADS=OFF` instead of `THREADSAFE=OFF` to better support the other cmake semantics. Nanosecond support is the default _if_ we can detect it. This should be our default always - like threads - and people can opt out explicitly.
* win32: include correct path headerethomson/pathEdward Thomson2021-11-094-4/+4
|
* fs_path: remove now-unused validation functionsEdward Thomson2021-11-092-68/+0
|
* fs_path: add length with suffix validationEdward Thomson2021-11-094-3/+30
|
* path: use new length validation functionsEdward Thomson2021-11-0910-20/+36
|
* path: length validation respecting core.longpathsEdward Thomson2021-11-092-0/+50
| | | | | Teach `git_path_is_valid` to respect `core.longpaths`. Add helper methods to validate length and set the error message appropriately.
* path: introduce `git_path_str_is_valid`Edward Thomson2021-11-094-11/+21
| | | | | Add a `git_str` based validity check; the existing `git_path_is_valid` defers to it.
* fs_path: add long path validation on windowsEdward Thomson2021-11-093-4/+37
|
* fs_path: make empty component validation optionalEdward Thomson2021-11-092-2/+8
|
* fs_path: introduce `str_is_valid`Edward Thomson2021-11-092-19/+54
| | | | | | | | | | Provide a mechanism for users to limit the number of characters that are examined; `git_fs_path_str_is_valid` and friends will only examine up to `str->size` bytes. `git_fs_path_is_valid` delegates to these new functions by passing `SIZE_MAX` (instead of doing a `strlen`), which is a sentinel value meaning "look for a NUL terminator".
* path: `validate` -> `is_valid`Edward Thomson2021-11-097-9/+9
| | | | | Since we're returning a boolean about validation, the name is more properly "is valid".
* fs_path: `validate` -> `is_valid`Edward Thomson2021-11-093-6/+6
| | | | | Since we're returning a boolean about validation, the name is more properly "is valid".
* path: separate git-specific path functions from utilEdward Thomson2021-11-0944-2822/+2939
| | | | | | Introduce `git_fs_path`, which operates on generic filesystem paths. `git_path` will be kept for only git-specific path functionality (for example, checking for `.git` in a path).
* cmake: stylistic refactoringEdward Thomson2021-10-181-283/+285
| | | | | Ensure that we always use lowercase function names, and that we do not have spaces preceding open parentheses, for consistency.
* trace: always enabledEdward Thomson2021-10-184-37/+0
| | | | There's no need to make tracing opt-in; it should always be included.
* str: introduce `git_str` for internal, `git_buf` is externalethomson/gitstrEdward Thomson2021-10-17148-3723/+4231
| | | | | | | | | | | | | | | | | | | | | | | | | | | libgit2 has two distinct requirements that were previously solved by `git_buf`. We require: 1. A general purpose string class that provides a number of utility APIs for manipulating data (eg, concatenating, truncating, etc). 2. A structure that we can use to return strings to callers that they can take ownership of. By using a single class (`git_buf`) for both of these purposes, we have confused the API to the point that refactorings are difficult and reasoning about correctness is also difficult. Move the utility class `git_buf` to be called `git_str`: this represents its general purpose, as an internal string buffer class. The name also is an homage to Junio Hamano ("gitstr"). The public API remains `git_buf`, and has a much smaller footprint. It is generally only used as an "out" param with strict requirements that follow the documentation. (Exceptions exist for some legacy APIs to avoid breaking callers unnecessarily.) Utility functions exist to convert a user-specified `git_buf` to a `git_str` so that we can call internal functions, then converting it back again.
* Merge pull request #6082 from libgit2/ethomson/oidEdward Thomson2021-10-1721-95/+118
|\ | | | | hash: separate hashes and git_oid
| * futils: use a particular hash not a git_oidEdward Thomson2021-10-022-7/+13
| | | | | | | | | | | | In `git_futils_readbuffer_updated`, always take a particular hash instead of a `git_oid`. This lets us change the checksum algorithm independently of `git_oid` usage.
| * hash: hash functions operate on byte arrays not git_oidsEdward Thomson2021-10-0219-42/+43
| | | | | | | | | | | | Separate the concerns of the hash functions from the git_oid functions. The git_oid structure will need to understand either SHA1 or SHA256; the hash functions should only deal with the appropriate one of these.
| * hash: accept the algorithm in inputsEdward Thomson2021-10-0113-50/+66
| |
| * hash: don't abbreviate algorithmEdward Thomson2021-10-012-13/+13
| |
* | diff: make the default rename_limit 1000Edward Thomson2021-10-131-1/+1
|/ | | git's default rename limit is 1000, ours should match.
* Merge pull request #6076 from libgit2/ethomson/oidarray_disposeEdward Thomson2021-09-272-2/+11
|\ | | | | oidarray: introduce `git_oidarray_dispose`
| * oidarray: introduce `git_oidarray_dispose`ethomson/oidarray_disposeEdward Thomson2021-09-262-2/+11
| | | | | | | | | | | | Since users are disposing the _contents_ of the oidarray, not freeing the oidarray itself, the proper cleanup function is `git_oidarray_dispose`. Deprecate `git_oidarray_free`.
* | Merge pull request #6075 from libgit2/ethomson/attr_longpathsEdward Thomson2021-09-274-9/+6
|\ \
| * | attr_file: don't take the `repo` as an argethomson/attr_longpathsEdward Thomson2021-09-264-7/+5
| | | | | | | | | | | | The `repo` argument is now unnecessary. Remove it.
| * | attr_file: don't validate workdir paths in attr lookupsEdward Thomson2021-09-261-2/+1
| |/ | | | | | | | | | | | | | | | | | | When looking up attributes for a file, we construct an absolute path to the queried file within the working directory so that we can accept both absolute paths and working directory relative paths. We then trim the leading working directory path to give us an in-repo path. Since we only want the in-repo path to look up attributes - and not to read it from disk - we don't need to validate its length.
* | Merge pull request #6073 from libgit2/ethomson/attr_lookupsEdward Thomson2021-09-275-23/+28
|\ \
| * | attr: ensure lookups are on repo-relative pathsethomson/attr_lookupsEdward Thomson2021-09-251-0/+2
| | | | | | | | | | | | | | | Attribute lookups are done on paths relative to the repository. Fail if erroneously presented with an absolute path.
| * | checkout: always provide a path for attribute lookupEdward Thomson2021-09-251-7/+6
| | | | | | | | | | | | | | | Always pass a working-directory relative path to attribute lookups during checkout.
| * | blob: improve `create_from_disk` attribute lookupsEdward Thomson2021-09-251-5/+4
| | | | | | | | | | | | | | | | | | Resolve absolute paths to be working directory relative when looking up attributes. Importantly, now we will _never_ pass an absolute path down to attribute lookup functions.
| * | repository: improve `hashfile` for absolute pathsEdward Thomson2021-09-251-11/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When `git_repository_hashfile` is handed an absolute path, it determines whether the path is within the repository's working directory or not. This is necessary when there is no `as_path` specified. If the path is within the working directory, then the given path should be used for attribute lookups (it is the effective `as_path`). If it is not within the working directory, then it is _not_ eligible. Importantly, now we will _never_ pass an absolute path down to attribute lookup functions.
| * | win32: posixify the output of p_getcwdEdward Thomson2021-09-251-0/+3
| |/ | | | | | | | | | | | | Make p_getcwd match the rest of our win32 path handling semantics. (This is currently only used in tests, which is why this disparity went unnoticed.)
* | buf: common_prefix takes a string arrayethomson/strarrayEdward Thomson2021-09-263-8/+9
|/ | | | | | `git_strarray` is a public-facing type. Change `git_buf_text_common_prefix` to not use it, and just take an array of strings instead.
* Merge pull request #6067 from libgit2/ethomson/filter_commit_idEdward Thomson2021-09-215-22/+58
|\ | | | | filter: use a `git_oid` in filter options, not a pointer
| * filter: use a `git_oid` in filter options, not a pointerethomson/filter_commit_idEdward Thomson2021-09-215-22/+58
| | | | | | | | | | | | | | Using a `git_oid *` in filter options was a mistake; it is a deviation from our typical pattern, and callers in some languages that GC may need very special treatment in order to pass both an options structure and a pointer outside of it.
* | email: don't clear buffer in append functionEdward Thomson2021-09-211-1/+0
|/ | | | | `git_email__append_from_diff` is meant to - well, append from a diff. Clearing the buffer, by definition, is not appending. Stop doing that.
* Merge pull request #6061 from libgit2/ethomson/emailEdward Thomson2021-09-205-173/+374
|\ | | | | Introduce `git_email_create`; deprecate `git_diff_format_email`
View Lorry Controller Status