From c690136c78075cc95ea4f1b9578f8133136299ee Mon Sep 17 00:00:00 2001 From: Patrick Steinhardt Date: Wed, 26 Feb 2020 19:34:49 +0100 Subject: deps: ntlmclient: fix htonll on big endian FreeBSD In commit 3828ea67b (deps: ntlmclient: fix missing htonll symbols on FreeBSD and SunOS, 2020-02-21), we've fixed compilation on BSDs due to missing `htonll` wrappers. While we are now using `htobe64` for both Linux and OpenBSD, we decided to use `bswap64` on FreeBSD. While correct on little endian systems, where we will swap from little- to big-endian, we will also do the swap on big endian systems. As a result, we do not use network byte order on such systems. Fix the issue by using htobe64, as well. --- deps/ntlmclient/compat.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/ntlmclient/compat.h b/deps/ntlmclient/compat.h index 43bc86564..555fa3fe4 100644 --- a/deps/ntlmclient/compat.h +++ b/deps/ntlmclient/compat.h @@ -32,7 +32,7 @@ #elif defined(__FreeBSD__) /* See man page bwaps64(9) */ # include -# define htonll bswap64 +# define htonll htobe64 #elif defined(sun) || defined(__sun) /* See man page byteorder(3SOCKET) */ # include -- cgit v1.2.1