From d1dbb3ae67c156093419157eaf2fc6b8281432b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?= Date: Wed, 12 Jul 2017 07:40:16 +0200 Subject: signature: don't leave a dangling pointer to the strings on parse failure If the signature is invalid but we detect that after allocating the strings, we free them. We however leave that pointer dangling in the structure the caller gave us, which can lead to double-free. Set these pointers to `NULL` after freeing their memory to avoid this. --- src/signature.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/signature.c b/src/signature.c index a56b8a299..25e0ee723 100644 --- a/src/signature.c +++ b/src/signature.c @@ -231,6 +231,7 @@ int git_signature__parse(git_signature *sig, const char **buffer_out, if (git__strtol64(&sig->when.time, time_start, &time_end, 10) < 0) { git__free(sig->name); git__free(sig->email); + sig->name = sig->email = NULL; return signature_error("invalid Unix timestamp"); } -- cgit v1.2.1